Issue 11369041: Merge 132985 - F4 inside <input type=time> should not open calendar picker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11369041: Merge 132985 - F4 inside <input type=time> should not open calendar picker (Closed)

Created:
8 years, 1 month ago by keishi

Modified:
8 years, 1 month ago

Reviewers:
keishi

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Visibility:
Public.

More Reviews

Description

Merge 132985 - F4 inside <input type=time> should not open calendar picker https://bugs.webkit.org/show_bug.cgi?id=100730 Reviewed by Kent Tamura. Source/WebCore: We lacked the check to see if the picker indicator is visible. Test: fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html * html/BaseMultipleFieldsDateAndTimeInputType.cpp: (WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): Check if picker indicator is visible. LayoutTests: * fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings-expected.txt: Added. * fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html: Added. TBR=keishi@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133258

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -3 lines)			Patch
M	LayoutTests/ChangeLog	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/ChangeLog	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages