Source/WebCore/ChangeLog - Issue 11369041: Merge 132985 - F4 inside <input type=time> should not open calendar picker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/ChangeLog

Issue 11369041: Merge 132985 - F4 inside <input type=time> should not open calendar picker (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« no previous file with comments | « LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings-expected.txt ('k') | Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/ChangeLog

===================================================================

--- Source/WebCore/ChangeLog (revision 133257)

+++ Source/WebCore/ChangeLog (working copy)

@@ -1,3 +1,17 @@

+2012-10-30 Keishi Hattori <keishi@webkit.org>

+ F4 inside <input type=time> should not open calendar picker

+ https://bugs.webkit.org/show_bug.cgi?id=100730

+ Reviewed by Kent Tamura.

+ We lacked the check to see if the picker indicator is visible.

+ Test: fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html

+ * html/BaseMultipleFieldsDateAndTimeInputType.cpp:

+ (WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): Check if picker indicator is visible.

2012-10-31 Keishi Hattori <keishi@webkit.org>

Calendar picker can flicker when opened from the suggestion picker