Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: Source/WebCore/ChangeLog

Issue 11369041: Merge 132985 - F4 inside <input type=time> should not open calendar picker (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 133257)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,3 +1,17 @@
+2012-10-30 Keishi Hattori <keishi@webkit.org>
+
+ F4 inside <input type=time> should not open calendar picker
+ https://bugs.webkit.org/show_bug.cgi?id=100730
+
+ Reviewed by Kent Tamura.
+
+ We lacked the check to see if the picker indicator is visible.
+
+ Test: fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html
+
+ * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
+ (WebCore::BaseMultipleFieldsDateAndTimeInputType::handleKeydownEvent): Check if picker indicator is visible.
+
2012-10-31 Keishi Hattori <keishi@webkit.org>
Calendar picker can flicker when opened from the suggestion picker

Powered by Google App Engine
This is Rietveld 408576698