Update Compile Step to Build Swarm Targets if Needed

Update Compile Step to Build Swarm Targets if Needed

This means that unless needed, the swarm files are not generated or upload to the isolate server.

R=maruel@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165481

[M-A Ruel, 2012-11-01 19:06:46]

lgtm

https://codereview.chromium.org/11369025/diff/1/scripts/master/factory/comman...
File scripts/master/factory/commands.py (right):

https://codereview.chromium.org/11369025/diff/1/scripts/master/factory/comman...
scripts/master/factory/commands.py:121:
swarm_tests.append(test_filter.split('_swarm:')[0])
swarm_tests.append(test_filter.split('_swarm:', 1)[0])

https://codereview.chromium.org/11369025/diff/1/scripts/master/factory/comman...
scripts/master/factory/commands.py:137: for swarm_test in swarm_tests:
command.extend(i + '_run' for i in swarm_tests)

[csharp, 2012-11-01 19:30:09]

Fixed comments and also added a target all when building swarm tests (since
otherwise it just builds the swarm targets and not the other items, which are
probably still needed).

PTAL and verify

https://codereview.chromium.org/11369025/diff/1/scripts/master/factory/comman...
File scripts/master/factory/commands.py (right):

https://codereview.chromium.org/11369025/diff/1/scripts/master/factory/comman...
scripts/master/factory/commands.py:121:
swarm_tests.append(test_filter.split('_swarm:')[0])
On 2012/11/01 19:06:46, Marc-Antoine Ruel wrote:
> swarm_tests.append(test_filter.split('_swarm:', 1)[0])

Done.

https://codereview.chromium.org/11369025/diff/1/scripts/master/factory/comman...
scripts/master/factory/commands.py:137: for swarm_test in swarm_tests:
On 2012/11/01 19:06:46, Marc-Antoine Ruel wrote:
> command.extend(i + '_run' for i in swarm_tests)

Done.

[M-A Ruel, 2012-11-01 19:34:21]

https://codereview.chromium.org/11369025/diff/5001/scripts/master/factory/com...
File scripts/master/factory/commands.py (right):

https://codereview.chromium.org/11369025/diff/5001/scripts/master/factory/com...
scripts/master/factory/commands.py:142: command.append('all')
My take: 'all' must be on the command line, or whatever target that needs to be
built.

I'd prefer to update master.cfg to include 'all' instead.

[csharp, 2012-11-01 19:58:36]

https://codereview.chromium.org/11369025/diff/5001/scripts/master/factory/com...
File scripts/master/factory/commands.py (right):

https://codereview.chromium.org/11369025/diff/5001/scripts/master/factory/com...
scripts/master/factory/commands.py:142: command.append('all')
On 2012/11/01 19:34:21, Marc-Antoine Ruel wrote:
> My take: 'all' must be on the command line, or whatever target that needs to
be
> built.
> 
> I'd prefer to update master.cfg to include 'all' instead.

Ok, 'all' is now added to the options for all bots that have swarm enabled.

[M-A Ruel, 2012-11-01 19:59:59]

lgtm

https://codereview.chromium.org/11369025/diff/3002/scripts/master/factory/swa...
File scripts/master/factory/swarm_commands.py (right):

https://codereview.chromium.org/11369025/diff/3002/scripts/master/factory/swa...
scripts/master/factory/swarm_commands.py:27: bStep.setProperty('swarm_tests', '
'.join(swarm_tests))
Why not keep it as a list?

I see it was a string before so while I'm asking here, it's outside the scope of
this CL, but conceptually it would have been better.

[csharp, 2012-11-01 20:05:25]

https://codereview.chromium.org/11369025/diff/3002/scripts/master/factory/swa...
File scripts/master/factory/swarm_commands.py (right):

https://codereview.chromium.org/11369025/diff/3002/scripts/master/factory/swa...
scripts/master/factory/swarm_commands.py:27: bStep.setProperty('swarm_tests', '
'.join(swarm_tests))
On 2012/11/01 20:00:00, Marc-Antoine Ruel wrote:
> Why not keep it as a list?
> 
> I see it was a string before so while I'm asking here, it's outside the scope
of
> this CL, but conceptually it would have been better.

I think I converted to a string because I didn't think any other values were
allowed (the testfilter getting converted to a string convinced me). Added a
TODO

[commit-bot: I haz the power, 2012-11-01 20:05:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/11369025/8005

[commit-bot: I haz the power, 2012-11-01 20:07:07]

Change committed as 165481