Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: scripts/master/factory/swarm_commands.py

Issue 11369025: Update Compile Step to Build Swarm Targets if Needed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/master/factory/commands.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/swarm_commands.py
diff --git a/scripts/master/factory/swarm_commands.py b/scripts/master/factory/swarm_commands.py
index f36bedec866f57474be7389cb422d758f1517b33..dc7085c6464fadec4be97985f814ed8853e708b8 100644
--- a/scripts/master/factory/swarm_commands.py
+++ b/scripts/master/factory/swarm_commands.py
@@ -20,18 +20,12 @@ def TestStepFilterSwarm(bStep):
build has swarm steps and thus if the test should run.
It also adds a property, swarm_tests, which contains all the tests which will
run under swarm."""
- bStep.setProperty('swarm_tests', '')
test_filters = bStep.build.getProperties().getProperty('testfilter')
test_filters = test_filters or commands.DEFAULT_TESTS
- swarm_tests = ''
- for test_filter in test_filters:
- if '_swarm:' in test_filter:
- swarm_tests += test_filter.split('_swarm:')[0] + ' '
- elif test_filter.endswith('_swarm'):
- swarm_tests += test_filter[:-len('_swarm')] + ' '
-
- bStep.setProperty('swarm_tests', swarm_tests.strip())
+ swarm_tests = commands.GetSwarmTestsFromTestFilter(test_filters)
+ # TODO(csharp): Keep swarm_tests as a list.
+ bStep.setProperty('swarm_tests', ' '.join(swarm_tests))
return bool(swarm_tests)
« no previous file with comments | « scripts/master/factory/commands.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698