Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1136893005: Respect quad->nearest_neighbor in SoftwareRenderer::DrawTextureQuad (Closed)

Created:
5 years, 7 months ago by ericrk
Modified:
5 years, 7 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Respect quad->nearest_neighbor in SoftwareRenderer::DrawTextureQuad Currently, SoftwareRenderer::DrawTextureQuad ignores quad->nearest_neighbor (it always uses nearest_neighbor). This leads to very poor scaling quality when certain content (such as videos) are scaled. This change causes DrawTextureQuad to use bilinear filtering unless quad->nearest_neighbor is true. This has some performance cost, but seemed worth it due to the very noticible quality issues that come with not filtering. BUG=458183 Committed: https://crrev.com/9bb374b668ecdc057bed01c658833939b07c48e3 Cr-Commit-Position: refs/heads/master@{#329903}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -0 lines) Patch
M cc/output/renderer_pixeltest.cc View 1 chunk +108 lines, -0 lines 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A cc/test/data/four_blue_green_checkers_linear.png View Binary file 0 comments Download

Messages

Total messages: 8 (3 generated)
ericrk
5 years, 7 months ago (2015-05-14 16:51:02 UTC) #3
enne (OOO)
lgtm, thanks for the test!
5 years, 7 months ago (2015-05-14 17:22:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136893005/20001
5 years, 7 months ago (2015-05-14 17:46:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-14 19:43:23 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 19:45:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bb374b668ecdc057bed01c658833939b07c48e3
Cr-Commit-Position: refs/heads/master@{#329903}

Powered by Google App Engine
This is Rietveld 408576698