runtime/lib/regexp_jsc.cc - Issue 11368138: Add some support for the code-point code-unit distinction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/regexp_jsc.cc

Issue 11368138: Add some support for the code-point code-unit distinction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: New version integrates feedback, adds less to standard String class. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/regexp_jsc.cc

diff --git a/runtime/lib/regexp_jsc.cc b/runtime/lib/regexp_jsc.cc

index 31cee70a1f59e91044cb4d09853dbaa8e4b0a870..a81f2134868f5dfd9e1d3adce8e397a08350f88e 100644

--- a/runtime/lib/regexp_jsc.cc

+++ b/runtime/lib/regexp_jsc.cc

@@ -19,7 +19,7 @@ static uint16_t* GetTwoByteData(const String& str) {

Zone* zone = Isolate::Current()->current_zone();

uint16_t* two_byte_str = zone->Alloc<uint16_t>(str.Length());

for (intptr_t i = 0; i < str.Length(); i++) {

- two_byte_str[i] = str.CharAt(i);

+ two_byte_str[i] = str.CodeUnitAt(i);

cshapiro 2012/11/15 20:14:51 Please do not change the name of this method on th

erikcorry 2012/11/15 23:47:05 The strings are now made up of UTF16 code units, n

}

return two_byte_str;

}

« no previous file with comments | « no previous file | runtime/lib/string.cc » ('j') | runtime/lib/string.cc » ('J')