Add some support for the code-point code-unit distinction.

runtime/lib/regexp_jsc.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // This file encapsulates all the interaction with the
 // JSC regular expression library also referred to as pcre
 
 #include "lib/regexp_jsc.h"
 
 #include "platform/assert.h"
 #include "vm/allocation.h"
 #include "vm/exceptions.h"
 #include "vm/globals.h"
 #include "vm/isolate.h"
 #include "third_party/jscre/pcre.h"
 
 namespace dart {
 
 static uint16_t* GetTwoByteData(const String& str) {
   Zone* zone = Isolate::Current()->current_zone();
   uint16_t* two_byte_str = zone->Alloc<uint16_t>(str.Length());
   for (intptr_t i = 0; i < str.Length(); i++) {
-    two_byte_str[i] = str.CharAt(i);
+    two_byte_str[i] = str.CodeUnitAt(i);

[cshapiro, 2012/11/15 20:14:51]

Please do not change the name of this method on the VM string class.

[erikcorry, 2012/11/15 23:47:05]

The strings are now made up of UTF16 code units, not characters.  However I have
renamed it since you prefer the old name.

   }
   return two_byte_str;
 }
 
 
 static void* JSREMalloc(size_t size) {
   intptr_t regexp_size = static_cast<intptr_t>(size);
   ASSERT(regexp_size > 0);
   const JSRegExp& new_regex = JSRegExp::Handle(JSRegExp::New(size));
   return new_regex.GetDataStartAddress();
@@ skipping 130 matching lines @@
        i += kMatchPair) {
     start = Smi::New(offsets[i]);
     end = Smi::New(offsets[i + 1]);
     array.SetAt(i, start);
     array.SetAt(i+1, end);
   }
   return array.raw();
 }
 
 }  // namespace dart