Issue 11368031: First step towards component build for Android.

Issue 11368031: First step towards component build for Android. (Closed)

Created:
8 years, 1 month ago by Yaron

Modified:
8 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, cjhopman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

First step towards component build for Android. Add symbol exports needed to build content shell. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165420

Patch Set 1 #

Total comments: 1

Patch Set 2 : indent #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -96 lines)			Patch
M	base/android/base_jni_registrar.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	base/android/jni_android.h	View		3 chunks	+31 lines, -28 lines	0 comments	Download
M	base/android/jni_array.h	View		1 chunk	+24 lines, -19 lines	0 comments	Download
M	base/android/jni_helper.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	base/android/jni_registrar.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	base/android/jni_string.h	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	base/android/locale_utils.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	base/android/path_utils.h	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	base/android/scoped_java_ref.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	base/message_pump_android.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	base/test/test_support_android.h	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	content/app/android/content_main.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/android/draw_delegate_impl.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/compositor_impl_android.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/public/app/android_library_loader_hooks.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/public/app/content_main.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/android/compositor.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	content/public/browser/android/draw_delegate.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	crypto/openssl_util.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	media/base/android/cookie_getter.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	media/base/android/media_jni_registrar.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	media/base/android/media_player_bridge.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	media/base/android/media_player_bridge_manager.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	net/android/net_jni_registrar.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	net/android/network_change_notifier_android.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/android/network_change_notifier_factory_android.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	net/android/network_library.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	net/base/network_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/android/ui_jni_registrar.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/gfx/android/gfx_jni_registrar.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	ui/gfx/android/java_bitmap.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/gl/gl_surface_android.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/gl/gl_surface_egl.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 1 month ago (2012-11-01 17:23:10 UTC) #2

lgtm

http://codereview.chromium.org/11368031/diff/1/content/browser/renderer_host/...
File content/browser/renderer_host/compositor_impl_android.h (right):

http://codereview.chromium.org/11368031/diff/1/content/browser/renderer_host/...
content/browser/renderer_host/compositor_impl_android.h:26: public
WebKit::WebLayerTreeViewClient {
indent

Expand Messages | Collapse Messages