Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1136803002: print on unused uniforms in debug builds (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

print on unused uniforms in debug builds BUG=skia: Committed: https://skia.googlesource.com/skia/+/af2d56d2139cc5597a5a43a4e16acbd8d10e9060

Patch Set 1 #

Patch Set 2 : print on unused #

Patch Set 3 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -13 lines) Patch
M src/gpu/gl/GrGLProgramDataManager.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramDataManager.cpp View 1 14 chunks +21 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
joshualitt
ignore the earlier CL, after talking with Brian I'm just going to change the assert ...
5 years, 7 months ago (2015-05-08 21:42:08 UTC) #2
robertphillips
lgtm
5 years, 7 months ago (2015-05-11 11:43:51 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136803002/40001
5 years, 7 months ago (2015-05-11 11:44:02 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-11 11:50:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1136803002/40001
5 years, 7 months ago (2015-05-11 13:21:24 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 13:21:38 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/af2d56d2139cc5597a5a43a4e16acbd8d10e9060

Powered by Google App Engine
This is Rietveld 408576698