Chromium Code Reviews
Help | Chromium Project | Sign in
(899)

Issue 11367081: Revert 165808 - Enable PlatformAppBrowserTest.DevToolsOpenedWithReload for debug builds. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by vandebo
Modified:
1 year, 5 months ago
Reviewers:
tapted
CC:
chromium-reviews_chromium.org, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 165808 - Enable PlatformAppBrowserTest.DevToolsOpenedWithReload for debug builds.

[28577:28577:1102/204920:1539270891:FATAL:ref_counted.cc(81)] Check failed: !in_dtor_.
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/22007

Webkit Roll in r165534 and fix in https://bugs.webkit.org/show_bug.cgi?id=100930
(WebKit revision 133188) means that this test will no longer cause a segfault
on Debug builds due to http://crbug.com/157097.

BUG=158283
TEST=browser_tests --gtest_filter=PlatformAppBrowserTest.DevToolsOpenedWithReload


Review URL: https://chromiumcodereview.appspot.com/11366052

TBR=tapted@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Lint Patch
M chrome/browser/extensions/platform_app_browsertest.cc View 1 chunk +11 lines, -1 line 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
vandebo
1 year, 5 months ago #1
tapted
1 year, 5 months ago #2
lgtm - thanks. I'll look into it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434