Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1136703003: Merge to XFA: Create top-level public/ header directory. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -4273 lines) Patch
M BUILD.gn View 2 chunks +15 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
D fpdfsdk/include/fpdf_dataavail.h View 1 chunk +0 lines, -223 lines 0 comments Download
D fpdfsdk/include/fpdf_ext.h View 1 chunk +0 lines, -108 lines 0 comments Download
D fpdfsdk/include/fpdf_flatten.h View 1 chunk +0 lines, -45 lines 0 comments Download
D fpdfsdk/include/fpdf_fwlevent.h View 1 chunk +0 lines, -286 lines 0 comments Download
D fpdfsdk/include/fpdf_progressive.h View 1 chunk +0 lines, -102 lines 0 comments Download
D fpdfsdk/include/fpdf_searchex.h View 1 chunk +0 lines, -33 lines 0 comments Download
D fpdfsdk/include/fpdf_sysfontinfo.h View 1 chunk +0 lines, -241 lines 0 comments Download
D fpdfsdk/include/fpdf_transformpage.h View 1 chunk +0 lines, -118 lines 0 comments Download
D fpdfsdk/include/fpdfdoc.h View 1 chunk +0 lines, -273 lines 0 comments Download
D fpdfsdk/include/fpdfedit.h View 1 chunk +0 lines, -281 lines 0 comments Download
D fpdfsdk/include/fpdfformfill.h View 1 chunk +0 lines, -1261 lines 0 comments Download
D fpdfsdk/include/fpdfppo.h View 1 chunk +0 lines, -46 lines 0 comments Download
D fpdfsdk/include/fpdfsave.h View 1 chunk +0 lines, -82 lines 0 comments Download
D fpdfsdk/include/fpdftext.h View 1 chunk +0 lines, -322 lines 0 comments Download
D fpdfsdk/include/fpdfview.h View 1 chunk +0 lines, -774 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 2 chunks +2 lines, -5 lines 0 comments Download
M fpdfsdk/include/fsdk_rendercontext.h View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PDFWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_dataavail_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_searchex.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfeditimg.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfformfill_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 3 chunks +16 lines, -14 lines 0 comments Download
A + public/fpdf_dataavail.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_doc.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_edit.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_ext.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_flatten.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_formfill.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_fwlevent.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_ppo.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_progressive.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_save.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_searchex.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_sysfontinfo.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_text.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_transformpage.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdfview.h View 1 chunk +2 lines, -0 lines 0 comments Download
M samples/pdfium_test.cc View 3 chunks +10 lines, -11 lines 0 comments Download
M testing/embedder_test.h View 1 chunk +4 lines, -4 lines 0 comments Download
M testing/embedder_test.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Lei, for review. Requires a few manual path fixes beyond simple merge. Thanks.
5 years, 7 months ago (2015-05-11 21:52:34 UTC) #2
Tom Sepez
Actually adding Lei.
5 years, 7 months ago (2015-05-11 21:53:02 UTC) #4
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-11 22:06:04 UTC) #5
Tom Sepez
5 years, 7 months ago (2015-05-11 22:25:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1ed8a21d5c26a9d78240d7d56850a1a4738d3f9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698