Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1364)

Issue 1135913002: Create top-level public/ header directory. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create top-level public/ header directory. These are the only files that embedders of PDFium should be including. They are entirely self-contained, and compile cleanly against -Wall so as to not offend the code that may include them. Having done this, we can see that chromium is pulling in two additional files from the fpdfsdk/include/pdfwindow directory, which is not guaranteed to work. A few files are renamed, adding an "_" to make the names consistent. The exception is fpdfview, which is doc'd as such in the doc. Naturally, paths will need updating in a handful of files in chrome when this rolls in. BUG=pdfium:154 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ac19d2d8f64ab87577f167e0a8df075a7fe3ffdc

Patch Set 1 #

Patch Set 2 : Restore missing file in pdfium.gyp #

Patch Set 3 : Make samples/pdfium_test.cc adhere to public/ only. #

Patch Set 4 : Reconstruct patch set, renames only. #

Patch Set 5 : Comment fpdfview.h non-rename. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -3653 lines) Patch
M BUILD.gn View 2 chunks +15 lines, -13 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
D fpdfsdk/include/fpdf_dataavail.h View 1 chunk +0 lines, -221 lines 0 comments Download
D fpdfsdk/include/fpdf_ext.h View 1 chunk +0 lines, -108 lines 0 comments Download
D fpdfsdk/include/fpdf_flatten.h View 1 chunk +0 lines, -42 lines 0 comments Download
D fpdfsdk/include/fpdf_fwlevent.h View 1 chunk +0 lines, -286 lines 0 comments Download
D fpdfsdk/include/fpdf_progressive.h View 1 chunk +0 lines, -94 lines 0 comments Download
D fpdfsdk/include/fpdf_searchex.h View 1 chunk +0 lines, -33 lines 0 comments Download
D fpdfsdk/include/fpdf_sysfontinfo.h View 1 chunk +0 lines, -241 lines 0 comments Download
D fpdfsdk/include/fpdf_transformpage.h View 1 chunk +0 lines, -113 lines 0 comments Download
D fpdfsdk/include/fpdfdoc.h View 1 2 3 4 1 chunk +0 lines, -269 lines 0 comments Download
D fpdfsdk/include/fpdfedit.h View 1 chunk +0 lines, -247 lines 0 comments Download
D fpdfsdk/include/fpdfformfill.h View 1 chunk +0 lines, -837 lines 0 comments Download
D fpdfsdk/include/fpdfppo.h View 1 chunk +0 lines, -43 lines 0 comments Download
D fpdfsdk/include/fpdfsave.h View 1 chunk +0 lines, -82 lines 0 comments Download
D fpdfsdk/include/fpdftext.h View 1 chunk +0 lines, -320 lines 0 comments Download
D fpdfsdk/include/fpdfview.h View 1 chunk +0 lines, -648 lines 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +2 lines, -5 lines 0 comments Download
M fpdfsdk/include/fsdk_rendercontext.h View 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PDFWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_dataavail.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_dataavail_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_searchex.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/fpdf_sysfontinfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfeditimg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfformfill_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdftext_embeddertest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 1 3 chunks +16 lines, -14 lines 0 comments Download
A + public/fpdf_dataavail.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_doc.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_edit.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_ext.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_flatten.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_formfill.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_fwlevent.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_ppo.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_progressive.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_save.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_searchex.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_sysfontinfo.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_text.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdf_transformpage.h View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + public/fpdfview.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M samples/pdfium_test.cc View 1 2 3 chunks +10 lines, -11 lines 0 comments Download
M testing/embedder_test.h View 1 chunk +4 lines, -4 lines 0 comments Download
M testing/embedder_test.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Tom Sepez
Lei, for review. Let me know what you think about this proposal. +jam@ for add'l ...
5 years, 7 months ago (2015-05-08 21:16:59 UTC) #2
Lei Zhang
Can we cleanup the whitespaces/tabs separately, so that git can figure out in this CL ...
5 years, 7 months ago (2015-05-08 23:57:36 UTC) #3
jam
On 2015/05/08 21:16:59, Tom Sepez wrote: > Lei, for review. Let me know what you ...
5 years, 7 months ago (2015-05-11 15:54:08 UTC) #4
Tom Sepez
On 2015/05/08 23:57:36, Lei Zhang wrote: > Can we cleanup the whitespaces/tabs separately, so that ...
5 years, 7 months ago (2015-05-11 16:42:37 UTC) #5
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-11 21:22:27 UTC) #6
Tom Sepez
5 years, 7 months ago (2015-05-11 21:27:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
ac19d2d8f64ab87577f167e0a8df075a7fe3ffdc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698