Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 11367026: [VS Addin] Add PNaCl configs to examples (Closed)

Created:
8 years, 1 month ago by Sam Clegg
Modified:
8 years, 1 month ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[VS Addin] Add PNaCl configs to examples. Also, cleanup link messages, and add missing arguments to PNaCl linker plugin. BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1463

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -34 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/PNaCl/Microsoft.Cpp.PNaCl.targets View 1 chunk +3 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln View 3 chunks +6 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/hello_nacl.vcxproj View 3 chunks +9 lines, -1 line 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp.sln View 3 chunks +6 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj View 4 chunks +9 lines, -25 lines 1 comment Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj View 1 chunk +4 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_world_gles/hello_world_gles/hello_world_gles.vcxproj.user View 1 chunk +12 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs View 2 chunks +2 lines, -2 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs View 1 chunk +1 line, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs View 2 chunks +4 lines, -3 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/UnitTests/PluginDebuggerGDBTest.cs View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
8 years, 1 month ago (2012-11-01 00:27:00 UTC) #1
binji
lgtm
8 years, 1 month ago (2012-11-01 18:30:55 UTC) #2
binji
http://codereview.chromium.org/11367026/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj File visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj (left): http://codereview.chromium.org/11367026/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj#oldcode150 visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj:150: <PostBuildEvent> what happens if you don't remove these from ...
8 years, 1 month ago (2012-11-01 18:32:43 UTC) #3
Sam Clegg
8 years, 1 month ago (2012-11-01 19:06:19 UTC) #4
On 2012/11/01 18:32:43, binji wrote:
>
http://codereview.chromium.org/11367026/diff/1/visual_studio/NativeClientVSAd...
> File
>
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj
> (left):
> 
>
http://codereview.chromium.org/11367026/diff/1/visual_studio/NativeClientVSAd...
>
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj:150:
> <PostBuildEvent>
> what happens if you don't remove these from the project files? Does it work?
> Will external developers have to do this too? Can we automate it?

If you have a post link phase that does create_nmf and they have the
automatic create nmf option enabled it will just run it twice which
will be confusing but harmless.

We will make sure that the new create nmf option is documents so that
developers know that they don't need to do this themselves anymore
(unless they want to).

I don't think we want to be changing their project files automatically
too much.
u

Powered by Google App Engine
This is Rietveld 408576698