visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs - Issue 11367026: [VS Addin] Add PNaCl configs to examples

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

Issue 11367026: [VS Addin] Add PNaCl configs to examples (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj ('K') | « visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs ('k') | visual_studio/NativeClientVSAddIn/UnitTests/PluginDebuggerGDBTest.cs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

diff --git a/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs b/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

index 9da21c0e79bc557894e65579b58642544f928f19..fe754a75cff06636aa4978206b5c40ab5431d768 100644

--- a/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

+++ b/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PluginDebuggerGDB.cs

@@ -63,9 +63,7 @@ namespace NativeClientVSAddIn

{

string arch = "i686";

if (Environment.Is64BitOperatingSystem)

- {

arch = "x86_64";

- }

if (!properties.IsPNaCl())

{

@@ -135,8 +133,11 @@ namespace NativeClientVSAddIn

if (properties.IsPNaCl())

{

string basename = Path.GetFileNameWithoutExtension(targetNexe_);

+ string suffix = "32";

+ if (Environment.Is64BitOperatingSystem)

+ suffix = "64";

targetNexe_ = Path.Combine(Path.GetDirectoryName(targetNexe_),

- basename + "_" + arch + ".nexe");

+ basename + "_" + suffix + ".nexe");

if (!File.Exists(targetNexe_))

{