Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: src/gurl_unittest.cc

Issue 11367010: Make ResolveRelative work with all hierarchical URLs. (Closed) Base URL: http://git.chromium.org/external/google-url.git@master
Patch Set: address Joth's feedback Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/url_canon_unittest.cc » ('j') | src/url_canon_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gurl_unittest.cc
diff --git a/src/gurl_unittest.cc b/src/gurl_unittest.cc
index f62267ff981627833df4ea3e1b5d70361d2e4498..6caf44e107094faa246cae47a7d6a45e3f712ce3 100644
--- a/src/gurl_unittest.cc
+++ b/src/gurl_unittest.cc
@@ -200,7 +200,7 @@ TEST(GURLTest, Resolve) {
// Unknown schemes are not standard.
{"data:blahblah", "http://google.com/", true, "http://google.com/"},
{"data:blahblah", "http:google.com", true, "http://google.com/"},
- {"data:/blahblah", "file.html", false, ""},
+ {"data:/blahblah", "file.html", true, "data:/file.html"},
brettw 2012/12/06 00:25:10 This case seems fine to me. But it seems like we s
mkosiba (inactive) 2012/12/06 16:57:33 Done.
// Filesystem URLs have different paths to test.
{"filesystem:http://www.google.com/type/", "foo.html", true, "filesystem:http://www.google.com/type/foo.html"},
{"filesystem:http://www.google.com/type/", "../foo.html", true, "filesystem:http://www.google.com/type/foo.html"},
« no previous file with comments | « no previous file | src/url_canon_unittest.cc » ('j') | src/url_canon_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698