Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: src/url_canon_unittest.cc

Issue 11367010: Make ResolveRelative work with all hierarchical URLs. (Closed) Base URL: http://git.chromium.org/external/google-url.git@master
Patch Set: address Joth's feedback Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/url_canon_unittest.cc
diff --git a/src/url_canon_unittest.cc b/src/url_canon_unittest.cc
index fbc44b7a0b3630baa65d7cb3a0893ae7b788edc2..73c3f496e40d5b0cc18844cf900dfa219edb6b3a 100644
--- a/src/url_canon_unittest.cc
+++ b/src/url_canon_unittest.cc
@@ -2036,6 +2036,15 @@ TEST(URLCanonTest, ResolveRelativeURL) {
{"filesystem:http://host/t/path", true, false, "./path2", true, true, true, "filesystem:http://host/t/path2"},
{"filesystem:http://host/t/path/", true, false, "path2", true, true, true, "filesystem:http://host/t/path/path2"},
{"filesystem:http://host/t/path", true, false, "filesystem:http:path2", true, false, false, NULL},
+ // Non-standard URLs.
brettw 2012/12/06 00:25:10 Can you expand on this comment a bit about what yo
mkosiba (inactive) 2012/12/06 16:57:33 Done.
+ {"about:blank", false, false, "content://content.Provider/", true, false, true, "content://content.Provider/"},
+ {"about:blank", false, false, "content://content.Provider", true, false, true, "content://content.Provider/"},
+ {"about:blank", false, false, "http://x/a", true, false, true, "http://x/a"},
+ {"content://content.Provider/a", true, false, "path", true, true, true, "content://content.Provider/path"},
+ {"content://content.Provider/a", true, false, "./path2", true, true, true, "content://content.Provider/path2"},
+ {"content://content.Provider/", true, false, "path3", true, true, true, "content://content.Provider/path3"},
+ {"content://content.Provider/", true, false, "../path4", true, true, true, "content://content.Provider/path4"},
+ {"content://content.Provider/", true, false, "http://host/", true, false, true, "http://host/"},
};
for (size_t i = 0; i < ARRAYSIZE(rel_cases); i++) {
« src/gurl_unittest.cc ('K') | « src/gurl_unittest.cc ('k') | src/url_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698