Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 1136693002: Chrome user menu shouldn't close if a tab steals focus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/signin/inline_login_handler.cc
diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc
index 11190a7af90fdb88ae6e0a0979c5e7ee9100a050..d84f77d58f6b32acb2b09ed360b75807961a803d 100644
--- a/chrome/browser/ui/webui/signin/inline_login_handler.cc
+++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc
@@ -15,10 +15,12 @@
#include "chrome/browser/signin/signin_promo.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/common/pref_names.h"
+#include "components/signin/core/common/profile_management_switches.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_ui.h"
#include "google_apis/gaia/gaia_urls.h"
#include "net/base/url_util.h"
+#include "ui/aura/window.h"
InlineLoginHandler::InlineLoginHandler() {}
@@ -136,5 +138,13 @@ void InlineLoginHandler::HandleSwitchToFullTabMessage(
ui::PAGE_TRANSITION_AUTO_TOPLEVEL);
chrome::Navigate(&params);
+ if (signin::GetSourceForPromoURL(main_frame_url) ==
+ signin_metrics::SOURCE_AVATAR_BUBBLE_SIGN_IN) {
+ gfx::NativeWindow top_level_window_ =
+ web_ui()->GetWebContents()->GetTopLevelNativeWindow();
+ if (top_level_window_ != nullptr)
+ top_level_window_->Hide();
+ }
Roger Tawa OOO till Jul 10th 2015/05/08 14:51:17 I guess you can' call ProfileChooserView::Hide() d
+
web_ui()->CallJavascriptFunction("inline.login.closeDialog");
}

Powered by Google App Engine
This is Rietveld 408576698