Chrome user menu shouldn't close if a tab steals focus

chrome/browser/ui/views/profiles/profile_chooser_view.cc

Index: chrome/browser/ui/views/profiles/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view.cc b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
index f55258026ec657bf0ba3466211ae3fa8ea3bc099..b80ee0eae3ce1747d4e0e58a1b151d467776fe76 100644
--- a/chrome/browser/ui/views/profiles/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profiles/profile_chooser_view.cc
@@ -686,6 +686,12 @@ void ProfileChooserView::ShowView(profiles::BubbleViewMode view_to_display,
   if (view_mode_ != profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER)
     tutorial_mode_ = profiles::TUTORIAL_MODE_NONE;
 
+  if (view_mode_ != profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER ||
+      tutorial_mode_ != profiles::TUTORIAL_MODE_NONE)
+    profile_bubble_->set_close_on_deactivate(false);
+  else
+    profile_bubble_->set_close_on_deactivate(close_on_deactivate_for_testing_);
+

[Roger Tawa OOO till Jul 10th, 2015/05/08 14:51:17]

Nit: since this is a multi-line/complex if-then-else you need all the { and }.

I'm not sure about the logic.  For example, as is this code will cause the menu
to be sticky if |view_mode_| is BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT or
BUBBLE_VIEW_MODE_ACCOUNT_REMOVAL.  It should only be sticky for the three web
view modes.

Also, for the tutorial, this makes the welcome and error tutorials sticky, which
is not what we want.

Did I miss something?

   layout->StartRow(1, 0);
   layout->AddView(sub_view);
   Layout();