Issue 11366201: [net] Fix parsing of HostCacheSize field trial group name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11366201: [net] Fix parsing of HostCacheSize field trial group name. (Closed)

Created:
8 years, 1 month ago by szym

Modified:
8 years, 1 month ago

Reviewers:
mmenke

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[net] Fix parsing of HostCacheSize field trial group name. The group name is <number><suffix>, e.g., 100A, so base::StringToSizeT will return false. BUG=114277, 143454 TEST=chrome --force-fieldtrials=HostCacheSize/8723suffix/; open 'chrome://net-internals/#dns' and verify 'Capacity: 8723' Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167254

Patch Set 1 #

Patch Set 2 : sync #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	net/base/host_cache.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages