Chromium Code Reviews
Help | Chromium Project | Sign in
(64)

Issue 11366201: [net] Fix parsing of HostCacheSize field trial group name. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by szym
Modified:
1 year, 5 months ago
Reviewers:
mmenke
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

[net] Fix parsing of HostCacheSize field trial group name.

The group name is <number><suffix>, e.g., 100A, so base::StringToSizeT will
return false.

BUG=114277, 143454
TEST=chrome --force-fieldtrials=HostCacheSize/8723suffix/; open 'chrome://net-internals/#dns' and verify 'Capacity: 8723'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167254

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Lint Patch
M net/base/host_cache.cc View 1 1 chunk +3 lines, -3 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
szym
1 year, 5 months ago #1
mmenke
1 year, 5 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6