Chromium Code Reviews
Help | Chromium Project | Sign in
(884)

Issue 11366132: Rollback of r12868, r12849 in trunk branch. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Sven Panne
Modified:
1 year, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Rollback of r12868, r12849 in trunk branch.

Fixed visibility attribute for GetPointerFromInternalField

Heavy cleanup of the external pointer API.

R=verwaest@chromium.org
BUG=Chrome 159674

Committed: https://code.google.com/p/v8/source/detail?r=12878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -526 lines) Lint Patch
M include/v8.h View 16 chunks +107 lines, -161 lines 0 comments 0 errors Download
M src/api.h View 4 chunks +3 lines, -3 lines 0 comments 0 errors Download
M src/api.cc View 6 chunks +134 lines, -116 lines 0 comments 0 errors Download
M src/bootstrapper.cc View 1 chunk +2 lines, -3 lines 0 comments 0 errors Download
M src/compiler.cc View 1 chunk +1 line, -3 lines 0 comments 0 errors Download
M src/contexts.h View 3 chunks +2 lines, -5 lines 0 comments 0 errors Download
M src/factory.h View 2 chunks +0 lines, -5 lines 0 comments ? errors Download
M src/factory.cc View 2 chunks +0 lines, -13 lines 0 comments ? errors Download
M src/heap.h View 2 chunks +1 line, -5 lines 0 comments ? errors Download
M src/heap.cc View 2 chunks +0 lines, -22 lines 0 comments 0 errors Download
M src/objects.h View 2 chunks +0 lines, -3 lines 0 comments 0 errors Download
M src/objects-inl.h View 1 chunk +0 lines, -8 lines 0 comments 0 errors Download
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -96 lines 0 comments 0 errors Download
M test/cctest/test-debug.cc View 1 chunk +0 lines, -3 lines 0 comments 0 errors Download
M test/cctest/test-decls.cc View 1 chunk +1 line, -2 lines 0 comments ? errors Download
M tools/grokdump.py View 1 chunk +74 lines, -76 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Sven Panne
1 year, 5 months ago #1
Toon Verwaest
1 year, 5 months ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6