Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 11366085: Fix control flow graph in the presence of aborting instructions in a try/catch/finally. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 14518)
+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)
@@ -1500,6 +1500,15 @@
}
}
+ visitExitTry(HExitTry node) {
+ // A [HExitTry] is used for having the control flow graph of a
floitsch 2012/11/05 14:24:52 An
ngeoffray 2012/11/05 16:58:07 Done.
+ // try/catch block right, ie the try body is always a predecessor
floitsch 2012/11/05 14:24:52 "right" is a strong word...
ngeoffray 2012/11/05 16:58:07 Comment updated.
+ // of the catch and finally. Here, we continue visiting the try
+ // body by visiting the block that contains the user-level control
+ // flow instruction.
+ visitBasicBlock(node.bodyTrySuccessor);
+ }
+
visitTry(HTry node) {
// We should never get here. Try/catch/finally is always handled using block
// information in [visitTryInfo], or not at all, in the case of the bailout

Powered by Google App Engine
This is Rietveld 408576698