Fix control flow graph in the presence of aborting instructions in a try/catch/finally.

sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaCodeGeneratorTask extends CompilerTask {
 
   final JavaScriptBackend backend;
 
@@ skipping 1482 matching lines @@
                       node);
       }
     } else {
       TargetElement target = node.target;
       if (!tryCallAction(continueAction, target)) {
         pushStatement(new js.Continue(null), node);
       }
     }
   }
 
+  visitExitTry(HExitTry node) {
+    // A [HExitTry] is used for having the control flow graph of a

[floitsch, 2012/11/05 14:24:52]

An

[ngeoffray, 2012/11/05 16:58:07]

Done.

+    // try/catch block right, ie the try body is always a predecessor

[floitsch, 2012/11/05 14:24:52]

"right" is a strong word...

[ngeoffray, 2012/11/05 16:58:07]

Comment updated.

+    // of the catch and finally. Here, we continue visiting the try
+    // body by visiting the block that contains the user-level control
+    // flow instruction.
+    visitBasicBlock(node.bodyTrySuccessor);
+  }
+
   visitTry(HTry node) {
     // We should never get here. Try/catch/finally is always handled using block
     // information in [visitTryInfo], or not at all, in the case of the bailout
     // generator.
     compiler.internalError('visitTry should not be called', instruction: node);
   }
 
   bool tryControlFlowOperation(HIf node) {
     if (!controlFlowOperators.contains(node)) return false;
     HPhi phi = node.joinBlock.phis.first;
@@ skipping 1620 matching lines @@
   if (leftType.canBeNull() && rightType.canBeNull()) {
     if (left.isConstantNull() || right.isConstantNull() ||
         (leftType.isPrimitive() && leftType == rightType)) {
       return '==';
     }
     return null;
   } else {
     return '===';
   }
 }