Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/java.gypi

Issue 1136573002: Use the Errorprone Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Extracted some constants Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/android/rules.gni ('K') | « build/host_jar.gypi ('k') | build/java_apk.gypi » ('j') | third_party/errorprone/errorprone.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/java.gypi
diff --git a/build/java.gypi b/build/java.gypi
index 716eb34beacc735d95e9fa43c756911a812433f8..ccfb9819ef48db2319ff8d24c156b168be9e3817 100644
--- a/build/java.gypi
+++ b/build/java.gypi
@@ -82,6 +82,8 @@
'run_findbugs%': 0,
'proguard_config%': '',
'proguard_preprocess%': '0',
+ 'enable_errorprone%': '0',
+ 'errorprone_exe_path': '<(PRODUCT_DIR)/bin.java/chromium_errorprone',
'variables': {
'variables': {
'proguard_preprocess%': 0,
@@ -256,6 +258,14 @@
'variables': {
'java_sources': ['>!@(find >(java_in_dir)/src >(additional_src_dirs) -name "*.java")'],
},
+ 'conditions': [
+ ['enable_errorprone == 1', {
+ 'extra_inputs': [
+ '<(errorprone_exe_path)',
+ ],
+ 'extra_args': [ '--errorprone-path=<(errorprone_exe_path)' ],
+ }],
+ ],
'inputs': [
'<(DEPTH)/build/android/gyp/util/build_utils.py',
'<(DEPTH)/build/android/gyp/javac.py',
« build/config/android/rules.gni ('K') | « build/host_jar.gypi ('k') | build/java_apk.gypi » ('j') | third_party/errorprone/errorprone.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698