Use the Errorprone Compiler

build/config/android/rules.gni

Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 6140b5eaa3c8ce718c8a9c3d5bfefc174ef01525..b67dd81d33773df28450287a9cb17b9d879b8fd8 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -732,6 +732,7 @@ template("java_strings_grd_prebuilt") {
 #     android_library target, for example.
 #
 #   chromium_code: If true, extra analysis warning/errors will be enabled.
+#   enable_errorprone: If true, enables the errorprone compiler.

[cjhopman, 2015/05/20 02:21:29]

What is our plan for enabling this? I don't think we really want to do it target
by target, but would rather have like a global on/off flag. Is that the case?

In the end I think we want a global on/off with a way for targets to explicitly
opt-out (like for errorprone itself). We probably wouldn't need an explicit
opt-in when it is globally off. As we ramp up, maybe we want to have the opt-in
while globally off.

In gyp, with this change, we essentially have global on/off with both opt-in and
opt-out. What do we want in gn?

[raywilliams_chromium, 2015/05/20 21:31:55]

Alright, I added a default to false.
I wasn't sure where to put it, so I put it right under chromium_code part.

[cjhopman, 2015/05/21 22:52:24]

That change seems to just set it to false for all apks. I don't think that's
what we want.

I think for apks, we should do the same as we are doing for java/android
libraries. Add an enable_errorprone arg and pass it to the java_library_impl.

To make it so that we have global on/off with explicit opt-in/out, add a flag in
the declare_args block in build/config/android/config.gni (maybe use_errorprone,
or use_errorprone_java_compiler, or something). Then, in compile_java where we
actually decide to use errorprone or not, do:

_enable_errorprone = use_errorprone_java_compiler
if (defined(invoker.enable_errorprone)) {
  _enable_errorprone = invoker.enable_errorprone
}

[raywilliams_chromium, 2015/05/22 17:09:55]

I'm still trying to figure out how these gni/gyp/gypi files work.
I'll give this another try.
Thanks for the review.

[raywilliams_chromium, 2015/05/26 15:12:45]

Done.

 #
 #   datadeps, testonly
 #
@@ -759,6 +760,9 @@ template("java_binary") {
     if (defined(invoker.deps)) {
       deps = invoker.deps
     }
+    if (defined(invoker.enable_errorprone)) {
+      enable_errorprone = invoker.enable_errorprone
+    }
     if (defined(invoker.java_files)) {
       java_files = invoker.java_files
     }
@@ -853,6 +857,8 @@ template("junit_binary") {
 #     ease the gyp->gn conversion and will be removed in the future.
 #
 #   chromium_code: If true, extra analysis warning/errors will be enabled.
+#   enable_errorprone: If true, enables the errorprone compiler.
+#
 #   jar_excluded_patterns: List of patterns of .class files to exclude from the
 #     final jar.
 #
@@ -901,6 +907,9 @@ template("java_library") {
     if (defined(invoker.deps)) {
       deps = invoker.deps
     }
+    if (defined(invoker.enable_errorprone)) {
+      enable_errorprone = invoker.enable_errorprone
+    }
     if (defined(invoker.jar_excluded_patterns)) {
       jar_excluded_patterns = invoker.jar_excluded_patterns
     }
@@ -992,6 +1001,8 @@ template("java_prebuilt") {
 #     ease the gyp->gn conversion and will be removed in the future.
 #
 #   chromium_code: If true, extra analysis warning/errors will be enabled.
+#   enable_errorprone: If true, enables the errorprone compiler.
+#
 #   jar_excluded_patterns: List of patterns of .class files to exclude from the
 #     final jar.
 #
@@ -1037,6 +1048,9 @@ template("android_library") {
     if (defined(invoker.deps)) {
       deps = invoker.deps
     }
+    if (defined(invoker.enable_errorprone)) {
+      enable_errorprone = invoker.enable_errorprone
+    }
     if (defined(invoker.jar_excluded_patterns)) {
       jar_excluded_patterns = invoker.jar_excluded_patterns
     }