Use the Errorprone Compiler

build/config/android/rules.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//base/android/linker/config.gni")
 import("//build/config/android/config.gni")
 import("//build/config/android/internal_rules.gni")
 import("//tools/grit/grit_rule.gni")
 import("//tools/relocation_packer/config.gni")
 
@@ skipping 714 matching lines @@
 #   srcjar_deps: List of srcjar dependencies. The .java files in the srcjars
 #     will be added to java_files and be included in this library.
 #   srcjars: List of srcjars to be included in this library, together with the
 #     ones obtained from srcjar_deps.
 #
 #   bypass_platform_checks: Disables checks about cross-platform (Java/Android)
 #     dependencies for this target. This will allow depending on an
 #     android_library target, for example.
 #
 #   chromium_code: If true, extra analysis warning/errors will be enabled.
+#   enable_errorprone: If true, enables the errorprone compiler.

[cjhopman, 2015/05/20 02:21:29]

What is our plan for enabling this? I don't think we really want to do it target
by target, but would rather have like a global on/off flag. Is that the case?

In the end I think we want a global on/off with a way for targets to explicitly
opt-out (like for errorprone itself). We probably wouldn't need an explicit
opt-in when it is globally off. As we ramp up, maybe we want to have the opt-in
while globally off.

In gyp, with this change, we essentially have global on/off with both opt-in and
opt-out. What do we want in gn?

[raywilliams_chromium, 2015/05/20 21:31:55]

Alright, I added a default to false.
I wasn't sure where to put it, so I put it right under chromium_code part.

[cjhopman, 2015/05/21 22:52:24]

That change seems to just set it to false for all apks. I don't think that's
what we want.

I think for apks, we should do the same as we are doing for java/android
libraries. Add an enable_errorprone arg and pass it to the java_library_impl.

To make it so that we have global on/off with explicit opt-in/out, add a flag in
the declare_args block in build/config/android/config.gni (maybe use_errorprone,
or use_errorprone_java_compiler, or something). Then, in compile_java where we
actually decide to use errorprone or not, do:

_enable_errorprone = use_errorprone_java_compiler
if (defined(invoker.enable_errorprone)) {
  _enable_errorprone = invoker.enable_errorprone
}

[raywilliams_chromium, 2015/05/22 17:09:55]

I'm still trying to figure out how these gni/gyp/gypi files work.
I'll give this another try.
Thanks for the review.

[raywilliams_chromium, 2015/05/26 15:12:45]

Done.

 #
 #   datadeps, testonly
 #
 # Example
 #   java_binary("foo") {
 #     java_files = [ "org/chromium/foo/FooMain.java" ]
 #     deps = [ ":bar_java" ]
 #     main_class = "org.chromium.foo.FooMain"
 #   }
 template("java_binary") {
   set_sources_assignment_filter([])
 
   # TODO(cjhopman): This should not act like a java_library for dependents (i.e.
   # dependents shouldn't get the jar in their classpath, etc.).
   java_library_impl(target_name) {
     if (defined(invoker.DEPRECATED_java_in_dir)) {
       DEPRECATED_java_in_dir = invoker.DEPRECATED_java_in_dir
     }
     if (defined(invoker.chromium_code)) {
       chromium_code = invoker.chromium_code
     }
     if (defined(invoker.datadeps)) {
       deps = invoker.datadeps
     }
     if (defined(invoker.deps)) {
       deps = invoker.deps
     }
+    if (defined(invoker.enable_errorprone)) {
+      enable_errorprone = invoker.enable_errorprone
+    }
     if (defined(invoker.java_files)) {
       java_files = invoker.java_files
     }
     if (defined(invoker.srcjar_deps)) {
       srcjar_deps = invoker.srcjar_deps
     }
     if (defined(invoker.srcjars)) {
       srcjars = invoker.srcjars
     }
     if (defined(invoker.bypass_platform_checks)) {
@@ skipping 74 matching lines @@
 #   java_files: List of .java files included in this library.
 #   srcjar_deps: List of srcjar dependencies. The .java files in the srcjars
 #     will be added to java_files and be included in this library.
 #   srcjars: List of srcjars to be included in this library, together with the
 #     ones obtained from srcjar_deps.
 #   DEPRECATED_java_in_dir: Directory containing java files. All .java files in
 #     this directory will be included in the library. This is only supported to
 #     ease the gyp->gn conversion and will be removed in the future.
 #
 #   chromium_code: If true, extra analysis warning/errors will be enabled.
+#   enable_errorprone: If true, enables the errorprone compiler.
+#
 #   jar_excluded_patterns: List of patterns of .class files to exclude from the
 #     final jar.
 #
 #   proguard_preprocess: If true, proguard preprocessing will be run. This can
 #     be used to remove unwanted parts of the library.
 #   proguard_config: Path to the proguard config for preprocessing.
 #
 #   supports_android: If true, Android targets (android_library, android_apk)
 #     may depend on this target. Note: if true, this target must only use the
 #     subset of Java available on Android.
@@ skipping 28 matching lines @@
     }
     if (defined(invoker.chromium_code)) {
       chromium_code = invoker.chromium_code
     }
     if (defined(invoker.datadeps)) {
       deps = invoker.datadeps
     }
     if (defined(invoker.deps)) {
       deps = invoker.deps
     }
+    if (defined(invoker.enable_errorprone)) {
+      enable_errorprone = invoker.enable_errorprone
+    }
     if (defined(invoker.jar_excluded_patterns)) {
       jar_excluded_patterns = invoker.jar_excluded_patterns
     }
     if (defined(invoker.java_files)) {
       java_files = invoker.java_files
     }
     if (defined(invoker.proguard_config)) {
       proguard_config = invoker.proguard_config
     }
     if (defined(invoker.proguard_preprocess)) {
@@ skipping 71 matching lines @@
 #   java_files: List of .java files included in this library.
 #   srcjar_deps: List of srcjar dependencies. The .java files in the srcjars
 #     will be added to java_files and be included in this library.
 #   srcjars: List of srcjars to be included in this library, together with the
 #     ones obtained from srcjar_deps.
 #   DEPRECATED_java_in_dir: Directory containing java files. All .java files in
 #     this directory will be included in the library. This is only supported to
 #     ease the gyp->gn conversion and will be removed in the future.
 #
 #   chromium_code: If true, extra analysis warning/errors will be enabled.
+#   enable_errorprone: If true, enables the errorprone compiler.
+#
 #   jar_excluded_patterns: List of patterns of .class files to exclude from the
 #     final jar.
 #
 #   proguard_preprocess: If true, proguard preprocessing will be run. This can
 #     be used to remove unwanted parts of the library.
 #   proguard_config: Path to the proguard config for preprocessing.
 #
 #   dex_path: If set, the resulting .dex.jar file will be placed under this
 #     path.
 #
@@ skipping 25 matching lines @@
     }
     if (defined(invoker.chromium_code)) {
       chromium_code = invoker.chromium_code
     }
     if (defined(invoker.datadeps)) {
       deps = invoker.datadeps
     }
     if (defined(invoker.deps)) {
       deps = invoker.deps
     }
+    if (defined(invoker.enable_errorprone)) {
+      enable_errorprone = invoker.enable_errorprone
+    }
     if (defined(invoker.jar_excluded_patterns)) {
       jar_excluded_patterns = invoker.jar_excluded_patterns
     }
     if (defined(invoker.java_files)) {
       java_files = invoker.java_files
     }
     if (defined(invoker.proguard_config)) {
       proguard_config = invoker.proguard_config
     }
     if (defined(invoker.proguard_preprocess)) {
@@ skipping 769 matching lines @@
 template("uiautomator_test") {
   set_sources_assignment_filter([])
   if (defined(invoker.testonly)) {
     testonly = invoker.testonly
   }
   assert(target_name != "")
   assert(invoker.deps != [] || true)
   group(target_name) {
   }
 }