Update Test262 to 5/30

Update Test262 to 5/30

This updates the test runner to run all tests in both sloppy
and strict mode.

It also marks the test in the status file as failing in
sloppy mode even if all it does is marking the test as
[PASS, FAIL]. A future CL will have to validate that the
tests pass and fail in the correct mode.

Committed: https://crrev.com/d869f4a4801d4ef6868c266c07f9e29d2e29cba5
Cr-Commit-Position: refs/heads/master@{#28879}

[arv (Not doing code reviews), 2015-06-05 22:52:11]

arv@chromium.org changed reviewers:
+ machenbach@chromium.org, rossberg@chromium.org

[arv (Not doing code reviews), 2015-06-05 23:14:48]

PTAL

[rossberg, 2015-06-08 09:41:34]

lgtm

https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
File test/test262-es6/test262-es6.status (right):

https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
test/test262-es6/test262-es6.status:243:
'built-ins/Set/prototype/forEach/this-arg-explicit-cannot-override-lexical-this-arrow':
[FAIL],
Urg, that test shouldn't be there. It's testing arrows, not the Set constructor.

https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
test/test262-es6/test262-es6.status:331:
'language/block-scope/leave/verify-context-in-finally-block': [PASS, ['sloppy',
FAIL]],
Hm, IIRC, the driver compares prefixes, so it might be possible to just say

'language/block-scope': [PASS, ['sloppy', FAIL]]

instead of listing all individual tests.

[Michael Achenbach, 2015-06-08 12:47:56]

Please make the first line of the description say also "Update Test262 to 5/30".
Otherwise the the commit message will say "This updates the test runner to run
all tests in both sloppy and strict mode."

[Michael Achenbach, 2015-06-08 12:57:08]

https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
File test/test262-es6/test262-es6.status (right):

https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
test/test262-es6/test262-es6.status:55:
'language/block-scope/leave/finally-block-let-declaration-only-shadows-outer-parameter-value-1':
[PASS, ['sloppy', FAIL]],
I don't completely understand this yet. 'sloppy' as a status keyword has no
effect yet, right? Wouldn't theses tests when run in sloppy mode incorrectly
pass?

[arv (Not doing code reviews), 2015-06-08 16:12:33]

On 2015/06/08 09:41:34, rossberg wrote:
> lgtm
> 
>
https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
> File test/test262-es6/test262-es6.status (right):
> 
>
https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
> test/test262-es6/test262-es6.status:243:
>
'built-ins/Set/prototype/forEach/this-arg-explicit-cannot-override-lexical-this-arrow':
> [FAIL],
> Urg, that test shouldn't be there. It's testing arrows, not the Set
constructor.
> 
>
https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
> test/test262-es6/test262-es6.status:331:
> 'language/block-scope/leave/verify-context-in-finally-block': [PASS,
['sloppy',
> FAIL]],
> Hm, IIRC, the driver compares prefixes, so it might be possible to just say
> 
> 'language/block-scope': [PASS, ['sloppy', FAIL]]
> 
> instead of listing all individual tests.

I'll try. I think it needs to be:

'language/block-scope/*': [PASS, ['sloppy', FAIL]]

[arv (Not doing code reviews), 2015-06-08 16:15:16]

https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
File test/test262-es6/test262-es6.status (right):

https://codereview.chromium.org/1136553008/diff/20001/test/test262-es6/test26...
test/test262-es6/test262-es6.status:55:
'language/block-scope/leave/finally-block-let-declaration-only-shadows-outer-parameter-value-1':
[PASS, ['sloppy', FAIL]],
On 2015/06/08 12:57:08, Michael Achenbach wrote:
> I don't completely understand this yet. 'sloppy' as a status keyword has no
> effect yet, right? Wouldn't theses tests when run in sloppy mode incorrectly
> pass?

Correct. Right now 'sloppy' always evaluates to 'sloppy' in the statusfile.py so
we always end up with [PASS, FAIL].

Another option is to just add an alias to this file:

FAIL_SLOPPY = [PASS, FAIL]

I think it is worht marking these differently for now and then once we make the
outcome dependent on these expressions we can make sure that these tests pass
for strict and fail for sloppy.

[arv (Not doing code reviews), 2015-06-08 16:53:41]

Use wildcards in more places

[Michael Achenbach, 2015-06-09 07:23:07]

lgtm

[arv (Not doing code reviews), 2015-06-09 15:52:03]

Arrow functions are now staged

[arv (Not doing code reviews), 2015-06-09 17:12:01]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-06-09 17:12:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org, machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1136553008/#ps60001
(title: "Arrow functions are now staged")

[commit-bot: I haz the power, 2015-06-09 17:12:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1136553008/60001

[commit-bot: I haz the power, 2015-06-09 17:27:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-09 17:27:45]

Patchset 4 (id:??) landed as
https://crrev.com/d869f4a4801d4ef6868c266c07f9e29d2e29cba5
Cr-Commit-Position: refs/heads/master@{#28879}

[Michael Achenbach, 2015-06-10 06:36:26]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1173933002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Still lots of breakages on some builders.
E.g.
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap/builds....

[arv (Not doing code reviews), 2015-06-10 14:52:33]

This is clearly the \r bug I was talking about... see the error message:

Error reading
'/mnt/data/b/build/slave/linux/build/v8/test/test262-es6/data/harness/assert.js
'

Notice the newline after assert.js

I made a PR to the upstream repo. I will try again once that has landed.

[arv (Not doing code reviews), 2015-06-10 14:52:39]

LGT<

[arv (Not doing code reviews), 2015-06-10 14:52:42]

LGTM