Extensions: Store disable reasons in Sync

chrome/browser/extensions/extension_service.h

Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 04d0f4ed8b40b12a2a453cfebc1f5a26fafbb82f..aa7b2ff9c42b50a293c9da0b738e25d19b019a8c 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -279,11 +279,13 @@ class ExtensionService
   // nothing.
   virtual void EnableExtension(const std::string& extension_id);
 
-  // Disables the extension.  If the extension is already disabled, or
-  // cannot be disabled, does nothing.
+  // Disables the extension. If the extension is already disabled, just adds
+  // the |disable_reasons|. If the extension cannot be disabled (due to policy),
+  // does nothing.
+  // Note that |disable_reasons| may be a bitmask of multiple reasons.

[not at google - send to devlin, 2015/05/12 18:04:17]

Could you change the argument to be an int? Bitmasks of enums don't make sense
as that type's enum, and can lead to funky state behaviour if they're
accidentally used inside a switch statement.

[Marc Treib, 2015/05/19 12:12:03]

Done.

[not at google - send to devlin, 2015/05/19 14:32:10]

Thanks. One last request: add a quick note how multiple disables makes sense /
when it might occur. It seems odd at first glance.

[Marc Treib, 2015/05/19 15:30:55]

Done.

   virtual void DisableExtension(
       const std::string& extension_id,
-      extensions::Extension::DisableReason disable_reason);
+      extensions::Extension::DisableReason disable_reasons);
 
   // Disable non-default and non-managed extensions with ids not in
   // |except_ids|. Default extensions are those from the Web Store with