Extensions: Store disable reasons in Sync

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 261 matching lines @@
   // deletion is done or at least is scheduled.
   virtual bool UninstallExtension(const std::string& extension_id,
                                   extensions::UninstallReason reason,
                                   const base::Closure& deletion_done_callback,
                                   base::string16* error);
 
   // Enables the extension.  If the extension is already enabled, does
   // nothing.
   virtual void EnableExtension(const std::string& extension_id);
 
-  // Disables the extension.  If the extension is already disabled, or
-  // cannot be disabled, does nothing.
+  // Disables the extension. If the extension is already disabled, just adds
+  // the |disable_reasons|. If the extension cannot be disabled (due to policy),
+  // does nothing.
+  // Note that |disable_reasons| may be a bitmask of multiple reasons.

[not at google - send to devlin, 2015/05/12 18:04:17]

Could you change the argument to be an int? Bitmasks of enums don't make sense
as that type's enum, and can lead to funky state behaviour if they're
accidentally used inside a switch statement.

[Marc Treib, 2015/05/19 12:12:03]

Done.

[not at google - send to devlin, 2015/05/19 14:32:10]

Thanks. One last request: add a quick note how multiple disables makes sense /
when it might occur. It seems odd at first glance.

[Marc Treib, 2015/05/19 15:30:55]

Done.

   virtual void DisableExtension(
       const std::string& extension_id,
-      extensions::Extension::DisableReason disable_reason);
+      extensions::Extension::DisableReason disable_reasons);
 
   // Disable non-default and non-managed extensions with ids not in
   // |except_ids|. Default extensions are those from the Web Store with
   // |was_installed_by_default| flag.
   void DisableUserExtensions(const std::vector<std::string>& except_ids);
 
   // Puts all extensions in a blocked state: Unloading every extension, and
   // preventing them from ever loading until UnblockAllExtensions is called.
   // This state is stored in preferences, so persists until Chrome restarts.
   //
@@ skipping 466 matching lines @@
                            GreylistUnknownDontChange);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            ManagementPolicyProhibitsEnableOnInstalled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            BlockAndUnblockBlacklistedExtension);
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_