Chromium Code Reviews
Help | Chromium Project | Sign in
(284)

Issue 11365249: drive: Event logger for chrome:drive-internals. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by kinaba
Modified:
1 year, 5 months ago
Reviewers:
satorux1
CC:
chromium-reviews_chromium.org, nkostylev+watch_chromium.org, achuith+watch_chromium.org, arv, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Event logger for chrome:drive-internals.

BUG=158005
TEST=Open chrome:drive-internals, and verify "Event Log" section is added.
TBR=sky@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=167647

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Review fix (#2, #3). #

Total comments: 8

Patch Set 3 : Review fix (#5) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -2 lines) Lint Patch
M chrome/browser/chromeos/drive/drive_system_service.h View 1 3 chunks +4 lines, -1 line 0 comments 0 errors Download
M chrome/browser/chromeos/drive/drive_system_service.cc View 5 chunks +8 lines, -1 line 0 comments ? errors Download
A chrome/browser/chromeos/drive/event_logger.h View 1 2 1 chunk +48 lines, -0 lines 0 comments ? errors Download
A chrome/browser/chromeos/drive/event_logger.cc View 1 2 1 chunk +30 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/resources/chromeos/drive_internals.html View 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/chromeos/drive_internals.js View 1 chunk +9 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 7 chunks +30 lines, -0 lines 0 comments 0 errors Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 9
kinaba
1 year, 5 months ago #1
satorux1
http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h File chrome/browser/chromeos/drive/event_logger.h (right): http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h#newcode16 chrome/browser/chromeos/drive/event_logger.h:16: class EventLogger { Class comment is missing. http://codereview.chromium.org/11365249/diff/1009/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc File ...
1 year, 5 months ago #2
satorux1
On 2012/11/14 05:55:11, satorux1 wrote: > http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h > File chrome/browser/chromeos/drive/event_logger.h (right): > > http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h#newcode16 > ...
1 year, 5 months ago #3
kinaba
http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h File chrome/browser/chromeos/drive/event_logger.h (right): http://codereview.chromium.org/11365249/diff/1009/chrome/browser/chromeos/drive/event_logger.h#newcode16 chrome/browser/chromeos/drive/event_logger.h:16: class EventLogger { On 2012/11/14 05:55:11, satorux1 wrote: > ...
1 year, 5 months ago #4
satorux1
LGTM with nits http://codereview.chromium.org/11365249/diff/8001/chrome/browser/chromeos/drive/event_logger.cc File chrome/browser/chromeos/drive/event_logger.cc (right): http://codereview.chromium.org/11365249/diff/8001/chrome/browser/chromeos/drive/event_logger.cc#newcode24 chrome/browser/chromeos/drive/event_logger.cc:24: history_.push_back(Event(next_event_id_++, what)); Let's increment this on ...
1 year, 5 months ago #5
kinaba
https://codereview.chromium.org/11365249/diff/8001/chrome/browser/chromeos/drive/event_logger.cc File chrome/browser/chromeos/drive/event_logger.cc (right): https://codereview.chromium.org/11365249/diff/8001/chrome/browser/chromeos/drive/event_logger.cc#newcode24 chrome/browser/chromeos/drive/event_logger.cc:24: history_.push_back(Event(next_event_id_++, what)); On 2012/11/14 07:59:30, satorux1 wrote: > Let's ...
1 year, 5 months ago #6
kinaba
TRBing sky@ for chrome/*.gyp change.
1 year, 5 months ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/11365249/12003
1 year, 5 months ago #8
I haz the power (commit-bot)
1 year, 5 months ago #9
Change committed as 167647
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6