Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java

Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix two pending TODO's. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java
diff --git a/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java b/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java
index 5f782b7ccc7a9ee0efaeeedf7980af48a87589d2..cc9926d4528303f8780dd71e0028be73a00f71bb 100644
--- a/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java
+++ b/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java
@@ -153,14 +153,6 @@ public class DartLibraryImplTest extends TestCase {
assertEquals(getDartLibCore(), new DartLibraryImpl(libSrc));
}
- /**
- * Test equals and sanity check that the core impl library can be accessed
- */
- public void test_DartLibraryImpl_equals_libCoreImpl() throws Exception {
- LibrarySource libSrc = getDartLibCoreImpl().getLibrarySourceFile();
- assertEquals(getDartLibCoreImpl(), new DartLibraryImpl(libSrc));
- }
-
public void test_DartLibraryImpl_equals_libDomWebkit() throws Exception {
// TODO (danrubel) uncomment to ensure webkit dom is bundled
//LibrarySource libSrc = getDartLibDomWebkit().getLibrarySourceFile();
@@ -650,11 +642,6 @@ public class DartLibraryImplTest extends TestCase {
assertDartLib3ImportedLibraries();
}
- public void test_DartLibraryImpl_getImportedLibraries_libCoreImpl() throws Exception {
- DartLibrary[] importedLibraries = getDartLibCoreImpl().getImportedLibraries();
- assertEquals(0, importedLibraries.length);
- }
-
public void test_DartLibraryImpl_getImportedLibraries_libEmpty() throws Exception {
DartLibrary[] importedLibraries = getDartLibEmpty().getImportedLibraries();
assertEquals(0, importedLibraries.length);
@@ -818,25 +805,10 @@ public class DartLibraryImplTest extends TestCase {
assertFalse(library.isTopLevel());
}
- public void xtest_DartLibraryImpl_getChildren_libCoreImpl() throws Exception {
- DartElement[] children = getDartLibCoreImpl().getChildren();
- // TODO(brianwilkerson) Disabled to fix the build. Either fix the test or remove it.
- assertContainsCompUnit(children, "coreimpl_runtime.dart", false, false);
- assertContainsCompUnit(children, "regexp.dart", false, false);
- assertContainsCompUnit(children, "array.dart", false, false);
- assertTrue(children.length > 10);
- }
-
- public void xtest_DartLibraryImpl_getElementName_libCoreImpl() throws Exception {
- // TODO(brianwilkerson) Disabled to fix the build. Either fix the test or remove it.
- assertEquals("dart:coreimpl", getDartLibCoreImpl().getElementName());
- }
-
- public void xtest_DartLibraryImpl_getImportedLibraries_libCore() throws Exception {
- // TODO(brianwilkerson) Disabled to fix the build. Either fix the test or remove it.
+ public void test_DartLibraryImpl_getImportedLibraries_libCore() throws Exception {
DartLibrary[] importedLibraries = getDartLibCore().getImportedLibraries();
assertEquals(1, importedLibraries.length);
- assertEquals("dart:coreimpl", importedLibraries[0].getElementName());
+ assertEquals("dart:collection", importedLibraries[0].getElementName());
}
public void xtest_DartLibraryImpl_isUnreferenced_imported() throws Exception {
@@ -1125,10 +1097,6 @@ public class DartLibraryImplTest extends TestCase {
return getBundledLib("dart:core");
}
- private DartLibraryImpl getDartLibCoreImpl() throws Exception {
- return (DartLibraryImpl) getDartLibCore().getImportedLibraries()[0];
- }
-
private DartLibraryImpl getDartLibEmpty() throws Exception {
if (dartLibEmpty == null) {
dartLibEmpty = getOrCreateDartLib("empty", null, null, null);

Powered by Google App Engine
This is Rietveld 408576698