compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java - Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java

Issue 11365196: Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix two pending TODO's. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/javatests/com/google/dart/compiler/PackageLibraryManagerTest.java ('k') | editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/model/DartLibraryImplTest.java » ('j') | runtime/lib/lib_sources.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java

diff --git a/compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java b/compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java

index 50b18c1281e87a20ab0699a38d41dc183c78de7c..4e205e4a8f0ddddec6546d72e95332aa2fe8755d 100644

--- a/compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java

+++ b/compiler/javatests/com/google/dart/compiler/SystemLibrariesReaderTest.java

@@ -43,19 +43,6 @@ public class SystemLibrariesReaderTest extends TestCase {

+ "\n could not find " + file);

}

- // check content

- // "coreimpl": const LibraryInfo(

- // "coreimpl/coreimpl_runtime.dart",

- // implementation: true,

- // dart2jsPath: "compiler/implementation/lib/coreimpl.dart",

- // dart2jsPatchPath: "compiler/implementation/lib/coreimpl_patch.dart")

- DartLibrary library = librariesMap.get("dart:coreimpl");

- assertTrue(library != null);

- assertEquals("dart:coreimpl",library.getShortName());

- assertTrue(library.isImplementation());

- assertEquals("Shared", library.getCategory());

}