Remove GetExtensionService from Profile.

chrome/browser/extensions/settings/settings_test_util.h

Index: chrome/browser/extensions/settings/settings_test_util.h
diff --git a/chrome/browser/extensions/settings/settings_test_util.h b/chrome/browser/extensions/settings/settings_test_util.h
index 7a1e8e47627fd07a770746e685d37fa5e9485818..d983b263cbdeccffebb7b7c0c78147fd85cbec81 100644
--- a/chrome/browser/extensions/settings/settings_test_util.h
+++ b/chrome/browser/extensions/settings/settings_test_util.h
@@ -71,9 +71,11 @@ class MockExtensionSystem : public TestExtensionSystem {
   virtual ~MockExtensionSystem();
 
   virtual EventRouter* event_router() OVERRIDE;
+  virtual ExtensionService* extension_service() OVERRIDE;

[Yoyo Zhou, 2012/11/21 00:27:13]

This doesn't feel right, in the places that it's used. Maybe what we need is to
also move GetMockExtensionService to this class?

[Miranda Callahan, 2012/11/26 22:14:24]

Hmm -- this would be nice, but unfortunately I don't think this will properly
exercise the tests. The issue is that when we use a MockExtensionSystem, we set
it as the Testing system through
ExtensionSystemFactory->SetTestingFactoryAndUse(MockExtensionSystem). This means
that every class that calls
extension::ExtensionSystem::Get(profile)->extension_service() will seamlessly
get the testing MockExtensionSystem, and call through to get the
MockExtensionService. At points in the test where we need the
MockExtensionService's ability to add an extension with a certain ID type, we
can downcast and trigger that capability. But it also means that code in the
general codebase that doesn't need that ability will Just Work -- for example,
the call on lines 174-176 of settings_frontend.cc. 

 
  private:
   scoped_ptr<EventRouter> event_router_;
+  MockExtensionService extension_service_;
 
   DISALLOW_COPY_AND_ASSIGN(MockExtensionSystem);
 };