Remove GetExtensionService from Profile.

chrome/browser/extensions/settings/settings_test_util.cc

Index: chrome/browser/extensions/settings/settings_test_util.cc
diff --git a/chrome/browser/extensions/settings/settings_test_util.cc b/chrome/browser/extensions/settings/settings_test_util.cc
index afb1ca0e4390d6e1a91d0d3cc33dc1e875cd7b14..3ccbd29bc054f8524e7b9dc0a11994ed07f66e69 100644
--- a/chrome/browser/extensions/settings/settings_test_util.cc
+++ b/chrome/browser/extensions/settings/settings_test_util.cc
@@ -118,6 +118,12 @@ EventRouter* MockExtensionSystem::event_router() {
   return event_router_.get();
 }
 
+ExtensionService* MockExtensionSystem::extension_service() {
+  ExtensionServiceInterface* as_interface =
+      static_cast<ExtensionServiceInterface*>(&extension_service_);

[Yoyo Zhou, 2012/11/21 00:27:13]

ditto

[Miranda Callahan, 2012/11/26 22:14:24]

Unfortunately, all this casting is needed, as MockExtensionService ISA
TestExtensionService ISA ExtensionServiceInterface -- this is the common
ancestor of the Mock and the actual ExtensionService. Which is just icky, but
maybe refactoring this can be in a separate CL.

[Yoyo Zhou, 2012/11/26 22:58:04]

You don't need it for the upcasting on this line, I thought.

[Miranda Callahan, 2012/11/29 17:36:35]

This probably needs refactoring to get rid of the confusion it's cost both of
us. :-P  This is actually a downcast -- we cast the MockExtensionSVC up to the
ExtensionSVCInterface, and then back down to an ExtensionSVC. The real question
is "how does this even work?" 

+  return static_cast<ExtensionService*>(as_interface);
+}
+
 ProfileKeyedService* BuildMockExtensionSystem(Profile* profile) {
   return new MockExtensionSystem(profile);
 }