Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2089)

Unified Diff: chrome/browser/policy/managed_mode_policy_provider.cc

Issue 11365112: Change PrefStore::ReadResult to a boolean. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/managed_mode_policy_provider.cc
diff --git a/chrome/browser/policy/managed_mode_policy_provider.cc b/chrome/browser/policy/managed_mode_policy_provider.cc
index 7fecdb183a849db3656846f481c5f1c8a485e708..11ed932f41e0907380883ee13ea085e2714579e7 100644
--- a/chrome/browser/policy/managed_mode_policy_provider.cc
+++ b/chrome/browser/policy/managed_mode_policy_provider.cc
@@ -77,20 +77,12 @@ void ManagedModePolicyProvider::OnInitializationCompleted(bool success) {
base::DictionaryValue* ManagedModePolicyProvider::GetCachedPolicy() const {
base::Value* value = NULL;
base::DictionaryValue* dict = NULL;
- PrefStore::ReadResult result = store_->GetMutableValue(kPolicies, &value);
- switch (result) {
- case PrefStore::READ_NO_VALUE: {
- dict = new base::DictionaryValue;
- store_->SetValue(kPolicies, dict);
- break;
- }
- case PrefStore::READ_OK: {
- bool success = value->GetAsDictionary(&dict);
- DCHECK(success);
- break;
- }
- default:
- NOTREACHED();
+ if (store_->GetMutableValue(kPolicies, &value)) {
+ bool success = value->GetAsDictionary(&dict);
+ DCHECK(success);
+ } else {
+ dict = new base::DictionaryValue;
+ store_->SetValue(kPolicies, dict);
}
return dict;

Powered by Google App Engine
This is Rietveld 408576698