Change PrefStore::ReadResult to a boolean.

base/prefs/default_pref_store.cc

Index: base/prefs/default_pref_store.cc
diff --git a/base/prefs/default_pref_store.cc b/base/prefs/default_pref_store.cc
index c031221496e54eeb89601c87ba09259ccf387ebc..3f902c44b5533c509a5b846433043e6418164ebd 100644
--- a/base/prefs/default_pref_store.cc
+++ b/base/prefs/default_pref_store.cc
@@ -9,18 +9,18 @@ using base::Value;
 DefaultPrefStore::DefaultPrefStore() {}
 
 void DefaultPrefStore::SetDefaultValue(const std::string& key, Value* value) {
-  CHECK(GetValue(key, NULL) == READ_NO_VALUE);
+  DCHECK(!GetValue(key, NULL));

[Mattias Nissler (ping if slow), 2012/11/08 10:29:58]

Why did you switch to a DCHECK here?

[Bernhard Bauer, 2012/11/08 12:18:28]

It seemed like the sort of internal invariant that we usually verify with
DCHECKs. Nothing horrible happens if this is compiled out in a Release build.

[Mattias Nissler (ping if slow), 2012/11/08 12:35:17]

Well, not here, but this would imply registering a preference twice, which would
indicate something gets initialized twice, which is something I'd prefer to
learn the dramatic way ;)

I agree though that we should only have DCHECKs here, can we upgrade the DCHECKS
in PrefService::RegisterPreference() and PrefService::UnregisterPreference()
CHECKs instead? WDYT?

[Bernhard Bauer, 2012/11/08 14:03:24]

Done.

   SetValue(key, value);
 }
 
 void DefaultPrefStore::RemoveDefaultValue(const std::string& key) {
-  CHECK(GetValue(key, NULL) == READ_OK);
+  DCHECK(GetValue(key, NULL));

[Mattias Nissler (ping if slow), 2012/11/08 10:29:58]

ditto

   RemoveValue(key);
 }
 
 base::Value::Type DefaultPrefStore::GetType(const std::string& key) const {
-  const Value* value;
-  return GetValue(key, &value) == READ_OK ? value->GetType() : Value::TYPE_NULL;
+  const Value* value = NULL;
+  return GetValue(key, &value) ? value->GetType() : Value::TYPE_NULL;
 }
 
 DefaultPrefStore::~DefaultPrefStore() {}