Chromium Code Reviews
Help | Chromium Project | Sign in
(172)

Issue 11365078: Add WebKit bugzilla/git search to my_activity.py (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by enne
Modified:
1 year, 5 months ago
Reviewers:
cmp, cjhopman
CC:
chromium-reviews_chromium.org, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Add WebKit bugzilla/git search to my_activity.py

This is unfortunately imperfect in a number of ways:

* Needs to get info from git commits, so needs a local WebKit git repo, and an explicit option to find it.
* Bugzilla doesn't return nearly as much information as other bug servers, and individual issues would have to be hit (and parsed) to get it.
* Searching for comments includes any issue ever commented on that was changed over the time period requested, so may have false positives.
* Reviews themselves can't be searched from Bugzilla, so can only be detected as "reviews" once landed and "issues" until then.

BUG=158993
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166100

Patch Set 1 #

Patch Set 2 : Parse WebKit git logs too #

Total comments: 8

Patch Set 3 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+273 lines, -0 lines) Lint Patch
M my_activity.py View 1 2 12 chunks +273 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 7
enne
1 year, 5 months ago #1
cjhopman
This is great, multiple people had requested WebKit integration (there's a bug filed at crbug.com/158933). ...
1 year, 5 months ago #2
enne
On 2012/11/04 16:32:03, cjhopman wrote: > Are all bugs on WebKit's buganizer public, or are ...
1 year, 5 months ago #3
cjhopman
lgtm.
1 year, 5 months ago #4
cmp
lgtm
1 year, 5 months ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/11365078/5001
1 year, 5 months ago #6
I haz the power (commit-bot)
1 year, 5 months ago #7
Change committed as 166100
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434