Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: components/autofill/core/browser/test_autofill_client.h

Issue 1136473006: Don't autofill credit cards on non-secure pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove default fallback for IsContextSecure, implement in inherited classes Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/test_autofill_client.h
diff --git a/components/autofill/core/browser/test_autofill_client.h b/components/autofill/core/browser/test_autofill_client.h
index 251181bccd2e4a8f7e738c30bc87d32eb7196130..e0940e174121626a109c295f02948971fde30077 100644
--- a/components/autofill/core/browser/test_autofill_client.h
+++ b/components/autofill/core/browser/test_autofill_client.h
@@ -56,7 +56,9 @@ class TestAutofillClient : public AutofillClient {
const base::string16& profile_full_name) override;
void OnFirstUserGestureObserved() override;
void LinkClicked(const GURL& url, WindowOpenDisposition disposition) override;
+ bool IsContextSecure(const GURL& form_origin) override;
Evan Stade 2015/06/29 17:38:54 nit: is_context_secure() const (and inline the imp
sigbjorn 2015/06/30 07:12:13 This is an override, so that means I'd have to cha
Evan Stade 2015/06/30 15:47:13 ah, yea, nevermind about that one
+ void SetContextSecurity(bool is_context_secure);
Evan Stade 2015/06/29 17:38:54 nit: set_is_context_secure() (and inline the impl)
void SetPrefs(scoped_ptr<PrefService> prefs) { prefs_ = prefs.Pass(); }
rappor::TestRapporService* test_rappor_service() {
@@ -70,6 +72,8 @@ class TestAutofillClient : public AutofillClient {
scoped_ptr<FakeIdentityProvider> identity_provider_;
scoped_ptr<rappor::TestRapporService> rappor_service_;
+ bool is_context_secure_;
+
DISALLOW_COPY_AND_ASSIGN(TestAutofillClient);
};

Powered by Google App Engine
This is Rietveld 408576698