Don't autofill credit cards on non-secure pages

components/autofill/core/browser/test_autofill_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_TEST_AUTOFILL_CLIENT_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_TEST_AUTOFILL_CLIENT_H_
 
 #include "base/compiler_specific.h"
 #include "base/i18n/rtl.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 38 matching lines @@
       const std::vector<base::string16>& labels) override;
   void HideAutofillPopup() override;
   bool IsAutocompleteEnabled() override;
   void PropagateAutofillPredictions(
       content::RenderFrameHost* rfh,
       const std::vector<autofill::FormStructure*>& forms) override;
   void DidFillOrPreviewField(const base::string16& autofilled_value,
                              const base::string16& profile_full_name) override;
   void OnFirstUserGestureObserved() override;
   void LinkClicked(const GURL& url, WindowOpenDisposition disposition) override;
+  bool IsContextSecure(const GURL& form_origin) override;

[Evan Stade, 2015/06/29 17:38:54]

nit: is_context_secure() const (and inline the impl)

(simple setters and getters are exceptions to the no-inline-in-header-file rule)

[sigbjorn, 2015/06/30 07:12:13]

This is an override, so that means I'd have to change the name of this function
elsewhere too. Elsewhere it is not a getter. Did you mean to change the name
throughout?

[Evan Stade, 2015/06/30 15:47:13]

ah, yea, nevermind about that one

 
+  void SetContextSecurity(bool is_context_secure);

[Evan Stade, 2015/06/29 17:38:54]

nit: set_is_context_secure() (and inline the impl)

   void SetPrefs(scoped_ptr<PrefService> prefs) { prefs_ = prefs.Pass(); }
 
   rappor::TestRapporService* test_rappor_service() {
     return rappor_service_.get();
   }
 
  private:
   // NULL by default.
   scoped_ptr<PrefService> prefs_;
   scoped_ptr<FakeOAuth2TokenService> token_service_;
   scoped_ptr<FakeIdentityProvider> identity_provider_;
   scoped_ptr<rappor::TestRapporService> rappor_service_;
 
+  bool is_context_secure_;
+
   DISALLOW_COPY_AND_ASSIGN(TestAutofillClient);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_TEST_AUTOFILL_CLIENT_H_