chrome/android/javatests_shell/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java - Issue 1136443004: Allow an Intent navigation even when a user types if a URL is server redirect and has an external p…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests_shell/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java

Issue 1136443004: Allow an Intent navigation even when a user types if a URL is server redirect and has an external p… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests_shell/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests_shell/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java

diff --git a/chrome/android/javatests_shell/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java b/chrome/android/javatests_shell/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java

index 39632a18d38f22244a05724470b4ca489dc8343f..73261419534fe3f91c7f6aa10753392de63b0264 100644

--- a/chrome/android/javatests_shell/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java

+++ b/chrome/android/javatests_shell/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java

@@ -213,12 +213,12 @@ public class TabRedirectHandlerTest extends InstrumentationTestCase {

TabRedirectHandler handler = new TabRedirectHandler(mContext);

handler.updateIntent(sYtIntent);

assertFalse(handler.isOnNavigation());

- assertFalse(handler.shouldStayInChrome());

+ assertFalse(handler.isNavigationFromUserTyping());

handler.updateNewUrlLoading(PageTransition.TYPED, false, false, 0, 0);

- assertTrue(handler.shouldStayInChrome());

+ assertTrue(handler.isNavigationFromUserTyping());

handler.updateNewUrlLoading(PageTransition.LINK, false, false, 0, 1);

- assertTrue(handler.shouldStayInChrome());

+ assertTrue(handler.isNavigationFromUserTyping());

assertTrue(handler.isOnNavigation());

assertEquals(0, handler.getLastCommittedEntryIndexBeforeStartingNavigation());

@@ -226,7 +226,7 @@ public class TabRedirectHandlerTest extends InstrumentationTestCase {

SystemClock.sleep(1);

handler.updateNewUrlLoading(

PageTransition.LINK, false, true, SystemClock.elapsedRealtime(), 2);

- assertFalse(handler.shouldStayInChrome());

+ assertFalse(handler.isNavigationFromUserTyping());

assertTrue(handler.isOnNavigation());

assertEquals(2, handler.getLastCommittedEntryIndexBeforeStartingNavigation());