chrome/android/javatests_shell/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java - Issue 1136443004: Allow an Intent navigation even when a user types if a URL is server redirect and has an external p…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests_shell/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 1136443004: Allow an Intent navigation even when a user types if a URL is server redirect and has an external p… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabRedirectHandler.java ('k') | chrome/android/javatests_shell/src/org/chromium/chrome/browser/tab/TabRedirectHandlerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests_shell/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

diff --git a/chrome/android/javatests_shell/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests_shell/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

index 69344668a4179c6d2e894d7c9199eab4ffce34e0..01477d6cd776b7934950a04d8e2d25e1795db8c7 100644

--- a/chrome/android/javatests_shell/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

+++ b/chrome/android/javatests_shell/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

@@ -381,7 +381,7 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {

@SmallTest

public void testTypedRedirectToExternalProtocol() {

- // http://crbug.com/331571 reverted http://crbug.com/169549

+ // http://crbug.com/169549

check("market://1234",

null, /* referrer */

false, /* incognito */

@@ -390,8 +390,8 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {

true,

false,

null,

- OverrideUrlLoadingResult.NO_OVERRIDE,

- IGNORE);

+ OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,

+ START_ACTIVITY);

// http://crbug.com/143118

check("market://1234",

null, /* referrer */

@@ -656,10 +656,10 @@ public class ExternalNavigationHandlerTest extends InstrumentationTestCase {

PageTransition.TYPED, NO_REDIRECT, true, false, redirectHandler,

OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);

- redirectHandler.updateNewUrlLoading(PageTransition.TYPED, true, false, 0, 0);

+ redirectHandler.updateNewUrlLoading(PageTransition.LINK, false, false, 0, 0);

check(INTENT_URL_WITH_FALLBACK_URL_WITHOUT_PACKAGE_NAME, null, /* referrer */

false, /* incognito */

- PageTransition.TYPED, REDIRECT, true, false, redirectHandler,

+ PageTransition.LINK, NO_REDIRECT, true, false, redirectHandler,

OverrideUrlLoadingResult.OVERRIDE_WITH_CLOBBERING_TAB, IGNORE);

// Now the user opens a link.