When using an Object as a set in Object.getOwnPropertyNames, null out the proto

When using an Object as a set in Object.getOwnPropertyNames, null out the proto

Also apply the same fix elsewhere in v8natives.js

BUG=v8:2410
Committed: https://code.google.com/p/v8/source/detail?r=12982

[adamk, 2012-11-14 21:52:36]

Let me know if there's another reviewer we should be sending random JS fixes
to...(this one was found by Rafael while we were looking at something else; I
decided to fix it while I was there).

[rossberg, 2012-11-15 14:23:10]

Nice catch!

https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js#newcode1069
src/v8natives.js:1069: var attributesClone = {};
While you're at it, could you apply the same fix here? :)

[adamk, 2012-11-15 14:33:30]

https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js#newcode1069
src/v8natives.js:1069: var attributesClone = {};
On 2012/11/15 14:23:11, rossberg wrote:
> While you're at it, could you apply the same fix here? :)

But then I'd need a test :).  Seems like a separate concern to me (and my Proxy
knowledge at this time in the morning is not so great)...

[rossberg, 2012-11-15 15:19:02]

On 2012/11/15 14:33:30, adamk wrote:
> https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js
> File src/v8natives.js (right):
> 
>
https://codereview.chromium.org/11364237/diff/3001/src/v8natives.js#newcode1069
> src/v8natives.js:1069: var attributesClone = {};
> On 2012/11/15 14:23:11, rossberg wrote:
> > While you're at it, could you apply the same fix here? :)
> 
> But then I'd need a test :).  Seems like a separate concern to me (and my
Proxy
> knowledge at this time in the morning is not so great)...

I'm fine without a test for that case.

[adamk, 2012-11-15 15:36:23]

Done.

[rossberg, 2012-11-15 15:39:36]

LGTM, will land.

https://codereview.chromium.org/11364237/diff/10001/src/v8natives.js
File src/v8natives.js (right):

https://codereview.chromium.org/11364237/diff/10001/src/v8natives.js#newcode973
src/v8natives.js:973: var names = { __proto__: null };  // TODO(rossberg): use
sets once they are ready.
Actually, this case was correct. ;)  But cannot harm either.

I'll fix the line length.