Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11364129: Added support for logging the output of failed flaky tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/testing/dart/test_runner.dart ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index cf13237b266ecf3beaab7817db1a53eaca2ed74d..5f7b7fe93271b51d03615928c10abe7e8857b5a9 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1351,6 +1351,14 @@ class TestUtils {
return vm;
}
+ static String flakyFileName() {
+ // If a flaky test did fail, infos about it (i.e. test name, stdin, stdout)
ricow1 2012/11/08 12:28:50 s/infos/info
+ // will be written to this file. This is useful for the debugging of
ricow1 2012/11/08 12:28:50 This is useful for debugging flaky tests.
+ // flaky tests.
+ // When running on a built bot, the file can be made visible in the waterfall UI.
ricow1 2012/11/08 12:28:50 Long line
ricow1 2012/11/08 12:28:50 s/built bot/buildbot
+ return ".flaky.log";
ahe 2012/11/09 10:35:02 I suggest that you remove the first dot.
+ }
+
static void ensureExists(String filename, Map configuration) {
if (!configuration['list'] && !(new File(filename).existsSync())) {
throw "Executable '$filename' does not exist";
« tools/testing/dart/test_runner.dart ('K') | « tools/testing/dart/test_runner.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698