Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 11364129: Added support for logging the output of failed flaky tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index c270a10eec2e6ce708dc3ebcb648388b49072c72..06845fafb6dd5242b64081bc06ea5a34a7aca6d8 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -167,6 +167,17 @@ class TestCase {
bool get usesWebDriver => TestUtils.usesWebDriver(configuration['runtime']);
void completed() { completedHandler(this); }
+
+ bool get isFlaky {
+ if (expectedOutcomes.contains(SKIP)) {
ahe 2012/11/09 10:35:02 Weird indentation.
+ return false;
+ }
+
+ var flags = new Set.from(expectedOutcomes);
+ flags..remove(TIMEOUT)
+ ..remove(SLOW);
+ return flags.contains(PASS) && flags.length > 1;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698