Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 11364129: Added support for logging the output of failed flaky tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index c270a10eec2e6ce708dc3ebcb648388b49072c72..8039e857a1e1d2510a3d2f668c4afcb472ff55c0 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -167,6 +167,17 @@ class TestCase {
bool get usesWebDriver => TestUtils.usesWebDriver(configuration['runtime']);
void completed() { completedHandler(this); }
+
+ bool isExpectedToBeFlaky() {
ricow1 2012/11/07 19:56:51 I would rename to flaky or isFlaky and I would con
kustermann 2012/11/08 09:15:13 Done.
+ if (expectedOutcomes.contains(SKIP)) {
+ return false;
+ }
+
+ var flags = new Set.from(expectedOutcomes);
+ flags.remove(TIMEOUT);
ricow1 2012/11/07 19:56:51 you can use cascades here if you like
kustermann 2012/11/08 09:15:13 Done.
+ flags.remove(SLOW);
+ return flags.contains(PASS) && flags.length > 1;
+ }
}
« tools/testing/dart/test_progress.dart ('K') | « tools/testing/dart/test_progress.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698