Added support for logging the output of failed flaky tests.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 149 matching lines @@
     final checked = configuration['checked'] ? '-checked' : '';
     return "$compiler-$runtime$checked ${mode}_$arch";
   }
 
   List<String> get batchRunnerArguments => ['-batch'];
   List<String> get batchTestArguments => commands.last.arguments;
 
   bool get usesWebDriver => TestUtils.usesWebDriver(configuration['runtime']);
 
   void completed() { completedHandler(this); }
+
+  bool isExpectedToBeFlaky() {

[ricow1, 2012/11/07 19:56:51]

I would rename to flaky or isFlaky and I would consider making it a getter

[kustermann, 2012/11/08 09:15:13]

Done.

+      if (expectedOutcomes.contains(SKIP)) {
+        return false;
+      }
+
+      var flags = new Set.from(expectedOutcomes);
+      flags.remove(TIMEOUT);

[ricow1, 2012/11/07 19:56:51]

you can use cascades here if you like

[kustermann, 2012/11/08 09:15:13]

Done.

+      flags.remove(SLOW);
+      return flags.contains(PASS) && flags.length > 1;
+  }
 }
 
 
 /**
  * BrowserTestCase has an extra compilation command that is run in a separate
  * process, before the regular test is run as in the base class [TestCase].
  * If the compilation command fails, then the rest of the test is not run.
  */
 class BrowserTestCase extends TestCase {
   /**
@@ skipping 1103 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }