Chromium Code Reviews
Help | Chromium Project | Sign in
(426)

Issue 11364062: ui: Remove TouchStatus in favour of EventResult. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by sadrul
Modified:
1 year, 5 months ago
CC:
chromium-reviews_chromium.org, tfarina, sadrul, dcheng, ben+watch_chromium.org
Visibility:
Public.

Description

ui: Remove TouchStatus in favour of EventResult.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165877

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -132 lines) Lint Patch
M ash/accelerators/accelerator_filter.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/accelerators/accelerator_filter.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/display/mouse_cursor_event_filter.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M ash/display/mouse_cursor_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/drag_drop/drag_drop_controller.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/drag_drop/drag_drop_controller.cc View 2 chunks +4 lines, -4 lines 0 comments ? errors Download
M ash/launcher/launcher_tooltip_manager.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M ash/launcher/launcher_tooltip_manager.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/magnifier/magnification_controller.cc View 2 chunks +3 lines, -3 lines 0 comments 0 errors Download
M ash/system/tray/tray_event_filter.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M ash/system/tray/tray_event_filter.cc View 1 chunk +3 lines, -3 lines 0 comments 0 errors Download
M ash/tooltips/tooltip_controller.h View 1 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/tooltips/tooltip_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M ash/touch/touch_observer_hud.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/touch/touch_observer_hud.cc View 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M ash/wm/app_list_controller.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M ash/wm/app_list_controller.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/wm/event_rewriter_event_filter.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/wm/event_rewriter_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/wm/overlay_event_filter.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/wm/overlay_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/wm/panel_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M ash/wm/panel_window_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/wm/shelf_layout_manager.cc View 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M ash/wm/system_gesture_event_filter.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/wm/system_gesture_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/wm/system_modal_container_event_filter.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/wm/system_modal_container_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/wm/user_activity_detector.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/wm/user_activity_detector.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ash/wm/window_cycle_controller.cc View 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M ash/wm/window_modality_controller.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/wm/window_modality_controller.cc View 1 chunk +3 lines, -3 lines 0 comments ? errors Download
M ash/wm/workspace/frame_maximize_button.cc View 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M ui/aura/event_filter.h View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ui/aura/event_filter.cc View 2 chunks +3 lines, -5 lines 0 comments ? errors Download
M ui/aura/root_window_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments ? errors Download
M ui/aura/shared/compound_event_filter_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ui/aura/shared/input_method_event_filter.h View 1 1 chunk +1 line, -1 line 0 comments ? errors Download
M ui/aura/shared/input_method_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
M ui/base/events/event_constants.h View 1 chunk +0 lines, -20 lines 0 comments ? errors Download
M ui/base/events/event_constants.cc View 1 1 chunk +0 lines, -28 lines 0 comments ? errors Download
M ui/ui.gyp View 1 1 chunk +0 lines, -1 line 0 comments ? errors Download
M ui/views/widget/x11_window_event_filter.h View 1 chunk +1 line, -1 line 0 comments ? errors Download
M ui/views/widget/x11_window_event_filter.cc View 1 chunk +2 lines, -2 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 5
sadrul
1 year, 5 months ago #1
tfarina
http://codereview.chromium.org/11364062/diff/1/ui/base/events/event_constants.h File ui/base/events/event_constants.h (right): http://codereview.chromium.org/11364062/diff/1/ui/base/events/event_constants.h#newcode5 ui/base/events/event_constants.h:5: #ifndef UI_BASE_EVENTS_EVENT_CONSTANTS_H_ Looking at this, we could split this ...
1 year, 5 months ago #2
tfarina
http://codereview.chromium.org/11364062/diff/1/ui/base/events/event_constants.cc File ui/base/events/event_constants.cc (right): http://codereview.chromium.org/11364062/diff/1/ui/base/events/event_constants.cc#newcode10 ui/base/events/event_constants.cc:10: Can you remove this file now?
1 year, 5 months ago #3
Ben Goodger (Google)
lgtm https://codereview.chromium.org/11364062/diff/1/ui/base/events/event_constants.h File ui/base/events/event_constants.h (right): https://codereview.chromium.org/11364062/diff/1/ui/base/events/event_constants.h#newcode5 ui/base/events/event_constants.h:5: #ifndef UI_BASE_EVENTS_EVENT_CONSTANTS_H_ On 2012/11/03 12:40:04, tfarina wrote: > ...
1 year, 5 months ago #4
sadrul
1 year, 5 months ago #5
http://codereview.chromium.org/11364062/diff/1/ui/base/events/event_constants.cc
File ui/base/events/event_constants.cc (right):

http://codereview.chromium.org/11364062/diff/1/ui/base/events/event_constants...
ui/base/events/event_constants.cc:10: 
On 2012/11/03 12:46:13, tfarina wrote:
> Can you remove this file now?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6