ui: Add IsExpressibleAsRect() method to RectF

ui: Add IsExpressibleAsRect() method to RectF

This method reports if the RectF can be safely converted to an
integer Rect. When it is false, some dimension of the RectF is
outside the bounds of what an integer can represent, and
converting it to a Rect will require clamping.

Tests:
ui_unittests:RectTest.IsExpressibleAsRect

R=sky
BUG=147395
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165725

[sky, 2012-11-02 17:54:30]

LGTM

I'm not to thrilled about the name, but I don't have anything better to suggest.

https://codereview.chromium.org/11364054/diff/1/ui/gfx/rect_f.h
File ui/gfx/rect_f.h (right):

https://codereview.chromium.org/11364054/diff/1/ui/gfx/rect_f.h#newcode43
ui/gfx/rect_f.h:43: bool IsExpressibleAsRect() const;
Add your description in the bug here.

https://codereview.chromium.org/11364054/diff/1/ui/gfx/safe_integer_conversio...
File ui/gfx/safe_integer_conversions.cc (right):

https://codereview.chromium.org/11364054/diff/1/ui/gfx/safe_integer_conversio...
ui/gfx/safe_integer_conversions.cc:14: return 0; // no int NaN.
nit: spacing is off.

[danakj, 2012-11-02 18:01:30]

Ya the name is not super exciting, but all I got is
"AllComponentsExpressibleAsIntegers()" or something. If that sparks an idea let
me know, otherwise I'll land with this one.

https://codereview.chromium.org/11364054/diff/1/ui/gfx/rect_f.h
File ui/gfx/rect_f.h (right):

https://codereview.chromium.org/11364054/diff/1/ui/gfx/rect_f.h#newcode43
ui/gfx/rect_f.h:43: bool IsExpressibleAsRect() const;
On 2012/11/02 17:54:30, sky wrote:
> Add your description in the bug here.

k!

https://codereview.chromium.org/11364054/diff/1/ui/gfx/safe_integer_conversio...
File ui/gfx/safe_integer_conversions.cc (right):

https://codereview.chromium.org/11364054/diff/1/ui/gfx/safe_integer_conversio...
ui/gfx/safe_integer_conversions.cc:14: return 0; // no int NaN.
On 2012/11/02 17:54:30, sky wrote:
> nit: spacing is off.

this is supposed to be fixing the spacing, but it looks weird here too. i'll
double check it.

[commit-bot: I haz the power, 2012-11-02 18:05:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11364054/7001

[commit-bot: I haz the power, 2012-11-02 18:11:35]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-02 18:21:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11364054/7001

[commit-bot: I haz the power, 2012-11-02 18:39:15]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.