Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 11364054: ui: Add IsExpressibleAsRect() method to RectF (Closed)

Created:
5 years ago by danakj
Modified:
5 years ago
Reviewers:
sky
CC:
chromium-reviews, cc-bugs_chromium.org, backer, piman
Visibility:
Public.

Description

ui: Add IsExpressibleAsRect() method to RectF This method reports if the RectF can be safely converted to an integer Rect. When it is false, some dimension of the RectF is outside the bounds of what an integer can represent, and converting it to a Rect will require clamping. Tests: ui_unittests:RectTest.IsExpressibleAsRect R=sky BUG=147395 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165725

Patch Set 1 #

Total comments: 4

Patch Set 2 : nits #

Messages

Total messages: 7 (0 generated)
danakj
5 years ago (2012-11-02 17:42:41 UTC) #1
sky
LGTM I'm not to thrilled about the name, but I don't have anything better to ...
5 years ago (2012-11-02 17:54:30 UTC) #2
danakj
Ya the name is not super exciting, but all I got is "AllComponentsExpressibleAsIntegers()" or something. ...
5 years ago (2012-11-02 18:01:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11364054/7001
5 years ago (2012-11-02 18:05:52 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
5 years ago (2012-11-02 18:11:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11364054/7001
5 years ago (2012-11-02 18:21:45 UTC) #6
commit-bot: I haz the power
5 years ago (2012-11-02 18:39:15 UTC) #7
Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld efc10ee0f