Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 11364047: Android doesn't have posix_memalign(), so use memalign() (Closed)

Created:
8 years, 1 month ago by Nikolay
Modified:
8 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Android doesn't have posix_memalign(), so use memalign() there instead. BUG=http://code.google.com/p/nativeclient/issues/detail?id=3032 TEST=Compiles, works Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10198

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/shared/platform/posix/aligned_malloc.c View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nikolay
8 years, 1 month ago (2012-11-02 10:07:06 UTC) #1
Mark Seaborn
https://codereview.chromium.org/11364047/diff/1/src/shared/platform/posix/aligned_malloc.c File src/shared/platform/posix/aligned_malloc.c (left): https://codereview.chromium.org/11364047/diff/1/src/shared/platform/posix/aligned_malloc.c#oldcode11 src/shared/platform/posix/aligned_malloc.c:11: Don't change the spacing unnecessarily, please. Two lines after ...
8 years, 1 month ago (2012-11-02 15:35:57 UTC) #2
Nikolay
PTAL. https://codereview.chromium.org/11364047/diff/1/src/shared/platform/posix/aligned_malloc.c File src/shared/platform/posix/aligned_malloc.c (left): https://codereview.chromium.org/11364047/diff/1/src/shared/platform/posix/aligned_malloc.c#oldcode11 src/shared/platform/posix/aligned_malloc.c:11: On 2012/11/02 15:35:57, Mark Seaborn wrote: > Don't ...
8 years, 1 month ago (2012-11-06 11:09:05 UTC) #3
Mark Seaborn
8 years, 1 month ago (2012-11-06 13:54:44 UTC) #4
LGTM

https://codereview.chromium.org/11364047/diff/1004/src/shared/platform/posix/...
File src/shared/platform/posix/aligned_malloc.c (right):

https://codereview.chromium.org/11364047/diff/1004/src/shared/platform/posix/...
src/shared/platform/posix/aligned_malloc.c:16: * luckily returns free()'able
memory.
How about: "luckily, in Bionic, returns free()'able memory, although it is not
required to in general."

Powered by Google App Engine
This is Rietveld 408576698