Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 113633006: testrequest is ignored. Also added wow64 attribute. (Closed)

Created:
7 years ago by Sorin Jianu
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

testrequest is ignored. Also added wow64 attribute. BUG=314521 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241138

Patch Set 1 #

Patch Set 2 : moved wow64 to request element. #

Total comments: 1

Messages

Total messages: 7 (0 generated)
Sorin Jianu
Turns out I forgot to port the "testrequest" when we migrated from v2 to v3. ...
7 years ago (2013-12-15 23:10:18 UTC) #1
waffles
lgtm
7 years ago (2013-12-16 18:34:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/113633006/20001
7 years ago (2013-12-16 20:05:56 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=185243
7 years ago (2013-12-16 23:49:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/113633006/20001
7 years ago (2013-12-16 23:59:25 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/113633006/diff/20001/chrome/browser/component_updater/test/component_updater_service_unittest.cc File chrome/browser/component_updater/test/component_updater_service_unittest.cc (right): https://codereview.chromium.org/113633006/diff/20001/chrome/browser/component_updater/test/component_updater_service_unittest.cc#newcode480 chrome/browser/component_updater/test/component_updater_service_unittest.cc:480: << post_interceptor_->GetRequestsAsString(); nice
7 years ago (2013-12-17 00:51:05 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-17 03:34:28 UTC) #7
Message was sent while issue was closed.
Change committed as 241138

Powered by Google App Engine
This is Rietveld 408576698